Author: tilman Date: Fri Jan 23 22:51:06 2015 New Revision: 1654426 URL: http://svn.apache.org/r1654426 Log: PDFBOX-2576: Using equalsIgnoreCase() is cleaner than using toUpperCase/toLowerCase().equals().; remove unused assignment
Modified: pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFToImage.java Modified: pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFToImage.java URL: http://svn.apache.org/viewvc/pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFToImage.java?rev=1654426&r1=1654425&r2=1654426&view=diff ============================================================================== --- pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFToImage.java (original) +++ pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFToImage.java Fri Jan 23 22:51:06 2015 @@ -191,7 +191,7 @@ public class PDFToImage { document = PDDocument.load(new File(pdfFile), password); - ImageType imageType = ImageType.RGB; + ImageType imageType; if ("bilevel".equalsIgnoreCase(color)) { imageType = ImageType.BINARY; @@ -291,7 +291,7 @@ public class PDFToImage String[] formats = ImageIO.getReaderFormatNames(); for( int i = 0; i < formats.length; i++ ) { - if(formats[i].toLowerCase().equals(formats[i])) + if (formats[i].equalsIgnoreCase(formats[i])) { retval.append( formats[i] ); if( i + 1 < formats.length )