svn commit: r1825048 - in /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive: annotation/PDAnnotationPopup.java digitalsignature/COSFilterInputStream.java form/AppearanceGeneratorHelper.java form/PDAcroForm.java

[msahyoun]

Author: msahyoun
Date: Thu Feb 22 11:41:14 2018
New Revision: 1825048

URL: http://svn.apache.org/viewvc?rev=1825048&view=rev
Log:
PDFBOX-4118: retain exception in log message; use LOG.debug for ignored 
exceptions

Modified:
    
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationPopup.java
    
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/COSFilterInputStream.java
    
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java
    
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java

Modified: 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationPopup.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationPopup.java?rev=1825048&r1=1825047&r2=1825048&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationPopup.java
 (original)
+++ 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationPopup.java
 Thu Feb 22 11:41:14 2018
@@ -18,6 +18,9 @@ package org.apache.pdfbox.pdmodel.intera
 
 import java.io.IOException;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+
 import org.apache.pdfbox.cos.COSDictionary;
 import org.apache.pdfbox.cos.COSName;
 
@@ -28,6 +31,7 @@ import org.apache.pdfbox.cos.COSName;
  */
 public class PDAnnotationPopup extends PDAnnotation
 {
+    private static final Log LOG = LogFactory.getLog(PDAnnotationPopup.class);
 
     /**
      * The type of annotation.
@@ -97,6 +101,7 @@ public class PDAnnotationPopup extends P
         }
         catch (IOException ioe)
         {
+            LOG.debug("An exception while trying to get the parent markup - 
ignoring", ioe);
             // Couldn't construct the annotation, so return null i.e. do 
nothing
         }
         return am;

Modified: 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/COSFilterInputStream.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/COSFilterInputStream.java?rev=1825048&r1=1825047&r2=1825048&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/COSFilterInputStream.java
 (original)
+++ 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/COSFilterInputStream.java
 Thu Feb 22 11:41:14 2018
@@ -22,9 +22,17 @@ import java.io.FilterInputStream;
 import java.io.IOException;
 import java.io.InputStream;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+
 
 public class COSFilterInputStream extends FilterInputStream
 {
+  /**
+  * Log instance.
+   */
+  private static final Log LOG = LogFactory.getLog(COSFilterInputStream.class);
+
   private final int[] byteRange;
   private long position = 0;
   
@@ -88,6 +96,7 @@ public class COSFilterInputStream extend
     }
     catch (IOException ee) 
     {
+      LOG.debug("An exception occured while trying to fill byte[] - ignoring", 
ee);
     }
     return i;
   }

Modified: 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java?rev=1825048&r1=1825047&r2=1825048&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java
 (original)
+++ 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java
 Thu Feb 22 11:41:14 2018
@@ -132,7 +132,7 @@ class AppearanceGeneratorHelper
                     }
                     catch (IOException e)
                     {
-                        LOG.warn("Unable to match field level font with 
AcroForm font");
+                        LOG.warn("Unable to match field level font with 
AcroForm font", e);
                     }
                 }
             }

Modified: 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java?rev=1825048&r1=1825047&r2=1825048&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java
 (original)
+++ 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java
 Thu Feb 22 11:41:14 2018
@@ -741,6 +741,7 @@ public final class PDAcroForm implements
                 {
                     // we can safely ignore the exception here
                     // as this might only cause a misplacement
+                    LOG.debug("Couldn't resolve possible need for translation 
- ignoring, content might be misplaced", e);
                 }
             }
             return needsTranslation;