svn commit: r1882711 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/COSWriter.java

[tilman]

Author: tilman
Date: Tue Oct 20 17:56:05 2020
New Revision: 1882711

URL: http://svn.apache.org/viewvc?rev=1882711&view=rev
Log:
PDFBOX-4997: summerize warning from Michael Klink as a comment

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/COSWriter.java

Modified: 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/COSWriter.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/COSWriter.java?rev=1882711&r1=1882710&r2=1882711&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/COSWriter.java 
(original)
+++ 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/COSWriter.java 
Tue Oct 20 17:56:05 2020
@@ -302,10 +302,14 @@ public class COSWriter implements ICOSVi
             COSBase object = 
cosDoc.getObjectFromPool(cosObjectKey).getObject();
             if (object != null && cosObjectKey!= null && !(object instanceof 
COSNumber))
             {
+                //FIXME see PDFBOX-4997: objectKeys is (theoretically) risky 
because a COSName in
+                // different objects would appear only once. Rev 1092855 
considered this
+                // but only for COSNumber.
+
                 objectKeys.put(object, cosObjectKey);
                 keyObject.put(cosObjectKey,object);
             }
-            
+
             if (cosObjectKey != null)
             {
                 long num = cosObjectKey.getNumber();