Author: tilman
Date: Mon Jan 20 10:40:06 2025
New Revision: 1923252

URL: http://svn.apache.org/viewvc?rev=1923252&view=rev
Log:
PDFBOX-5936:  refactor for future change

Modified:
    
pdfbox/branches/3.0/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java

Modified: 
pdfbox/branches/3.0/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java
URL: 
http://svn.apache.org/viewvc/pdfbox/branches/3.0/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java?rev=1923252&r1=1923251&r2=1923252&view=diff
==============================================================================
--- 
pdfbox/branches/3.0/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java
 (original)
+++ 
pdfbox/branches/3.0/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java
 Mon Jan 20 10:40:06 2025
@@ -369,19 +369,22 @@ public class AddValidationInformation
     private void addOcspData(CertSignatureInformation certInfo) throws 
IOException, OCSPException,
             CertificateProccessingException, RevokedCertificateException, 
URISyntaxException
     {
-        if (ocspChecked.contains(certInfo.getCertificate()))
+        X509Certificate certificate = certInfo.getCertificate();
+        X509Certificate issuerCertificate = certInfo.getIssuerCertificate();
+        String ocspURL = certInfo.getOcspUrl();
+        if (ocspChecked.contains(certificate))
         {
             // This certificate has been OCSP-checked before
             return;
         }
         OcspHelper ocspHelper = new OcspHelper(
-                certInfo.getCertificate(),
+                certificate,
                 signDate.getTime(),
-                certInfo.getIssuerCertificate(),
+                issuerCertificate,
                 new HashSet<>(certInformationHelper.getCertificateSet()),
-                certInfo.getOcspUrl());
+                ocspURL);
         OCSPResp ocspResp = ocspHelper.getResponseOcsp();
-        ocspChecked.add(certInfo.getCertificate());
+        ocspChecked.add(certificate);
         BasicOCSPResp basicResponse = (BasicOCSPResp) 
ocspResp.getResponseObject();
         X509Certificate ocspResponderCertificate = 
ocspHelper.getOcspResponderCertificate();
         certInformationHelper.addAllCertsFromHolders(basicResponse.getCerts());
@@ -423,7 +426,7 @@ public class AddValidationInformation
         {
             correspondingOCSPs.add(ocspStream);
         }
-        foundRevocationInformation.add(certInfo.getCertificate());
+        foundRevocationInformation.add(certificate);
     }
 
     /**


Reply via email to