svn commit: r1929337 - pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/image

[tilman]

Author: tilman
Date: Sat Oct 25 15:09:37 2025
New Revision: 1929337

Log:
PDFBOX-5660: close input, as suggested by Valery Bokov; closes #293

Modified:
   
pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/image/PNGConverterTest.java

Modified: 
pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/image/PNGConverterTest.java
==============================================================================
--- 
pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/image/PNGConverterTest.java
     Sat Oct 25 12:45:02 2025        (r1929336)
+++ 
pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/image/PNGConverterTest.java
     Sat Oct 25 15:09:37 2025        (r1929337)
@@ -27,6 +27,7 @@ import java.awt.image.WritableRaster;
 import java.io.ByteArrayInputStream;
 import java.io.File;
 import java.io.IOException;
+import java.io.InputStream;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
@@ -164,8 +165,11 @@ public class PNGConverterTest
 
     private void checkImageConvertFail(String name) throws IOException
     {
+        InputStream is = PNGConverterTest.class.getResourceAsStream(name);
+        byte[] imageBytes = IOUtils.toByteArray(is);
+        is.close();
+
         PDDocument doc = new PDDocument();
-        byte[] imageBytes = 
IOUtils.toByteArray(PNGConverterTest.class.getResourceAsStream(name));
         PDImageXObject pdImageXObject = PNGConverter.convertPNGImage(doc, 
imageBytes);
         assertNull(pdImageXObject);
         doc.close();
@@ -173,9 +177,11 @@ public class PNGConverterTest
 
     private void checkImageConvert(String name) throws IOException
     {
-        PDDocument doc = new PDDocument();
-        byte[] imageBytes = 
IOUtils.toByteArray(PNGConverterTest.class.getResourceAsStream(name));
+        InputStream is = PNGConverterTest.class.getResourceAsStream(name);
+        byte[] imageBytes = IOUtils.toByteArray(is);
+        is.close();
 
+        PDDocument doc = new PDDocument();
         PDImageXObject pdImageXObject = PNGConverter.convertPNGImage(doc, 
imageBytes);
         assertNotNull(pdImageXObject);
 
@@ -364,9 +370,11 @@ public class PNGConverterTest
     {
         checkImageConvert("929316.png");
 
-        PDDocument doc = new PDDocument();
+        InputStream is = 
PNGConverterTest.class.getResourceAsStream("929316.png");
+        byte[] imageBytes = IOUtils.toByteArray(is);
+        is.close();
 
-        byte[] imageBytes = 
IOUtils.toByteArray(PNGConverterTest.class.getResourceAsStream("929316.png"));
+        PDDocument doc = new PDDocument();
         PDImageXObject pdImageXObject = PNGConverter.convertPNGImage(doc, 
imageBytes);
         assertEquals(COSName.PERCEPTUAL, 
pdImageXObject.getCOSObject().getItem(COSName.INTENT));