Author: lehmi
Date: Sat Nov 1 08:27:51 2025
New Revision: 1929449
Log:
PDFBOX-6093: sonar finding, formating, remove commented test code
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java
==============================================================================
---
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java
Sat Nov 1 07:26:06 2025 (r1929448)
+++
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java
Sat Nov 1 08:27:51 2025 (r1929449)
@@ -262,7 +262,6 @@ public abstract class BaseParser
if (ch == ')')
{
-
braces--;
braces = checkForEndOfString(braces);
if (braces != 0)
@@ -279,25 +278,25 @@ public abstract class BaseParser
{
//patched by ram
char next = (char) source.read();
- switch(next)
+ switch (next)
{
- case 'n':
- out.write('\n');
- break;
- case 'r':
- out.write('\r');
- break;
- case 't':
- out.write('\t');
- break;
- case 'b':
- out.write('\b');
- break;
- case 'f':
- out.write('\f');
- break;
- case ')':
- // PDFBox 276 /Title (c:\)
+ case 'n':
+ out.write('\n');
+ break;
+ case 'r':
+ out.write('\r');
+ break;
+ case 't':
+ out.write('\t');
+ break;
+ case 'b':
+ out.write('\b');
+ break;
+ case 'f':
+ out.write('\f');
+ break;
+ case ')':
+ // PDFBox 276 /Title (c:\)
braces = checkForEndOfString(braces);
if (braces != 0)
{
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java
==============================================================================
---
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java
Sat Nov 1 07:26:06 2025 (r1929448)
+++
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java
Sat Nov 1 08:27:51 2025 (r1929449)
@@ -1249,7 +1249,7 @@ public class COSParser extends BaseParse
}
}
String endStream = readString();
- if (endStream.equals("endobj") && isLenient)
+ if (endStream.equals(ENDOBJ_STRING) && isLenient)
{
LOG.warn("stream ends with 'endobj' instead of 'endstream' at
offset {}",
source.getPosition());
@@ -1999,7 +1999,6 @@ public class COSParser extends BaseParse
*/
protected COSObjectKey getObjectKey(long num, int gen)
{
- // return new COSObjectKey(num, gen);
if (document == null || document.getXrefTable().isEmpty())
{
return new COSObjectKey(num, gen);