svn commit: r1929964 - in pdfbox/trunk/pdfbox/src: main/java/org/apache/pdfbox/pdmodel/fdf test/java/org/apache/pdfbox/pdmodel/fdf

[tilman]

Author: tilman
Date: Tue Nov 25 09:29:07 2025
New Revision: 1929964

Log:
PDFBOX-6104: fix border style initialization + add test, by Kai Keggenhoff

Modified:
   
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotation.java
   
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationTest.java

Modified: 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotation.java
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotation.java
  Tue Nov 25 08:58:08 2025        (r1929963)
+++ 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotation.java
  Tue Nov 25 09:29:07 2025        (r1929964)
@@ -301,8 +301,8 @@ public abstract class FDFAnnotation impl
                 }
                 borderStyle.setDashStyle(dashPattern);
             }
-            setBorderStyle(borderStyle);
         }
+        setBorderStyle(borderStyle);
     }
 
     final float[] parseRectangleAttributes(String rect, String errorMessage) 
throws IOException

Modified: 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationTest.java
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationTest.java
      Tue Nov 25 08:58:08 2025        (r1929963)
+++ 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationTest.java
      Tue Nov 25 09:29:07 2025        (r1929964)
@@ -16,18 +16,22 @@
  */
 package org.apache.pdfbox.pdmodel.fdf;
 
+import java.io.ByteArrayInputStream;
 import java.io.File;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.io.IOException;
 import java.net.URISyntaxException;
+import java.nio.charset.StandardCharsets;
 import java.util.List;
 
 import org.apache.pdfbox.Loader;
 
 import org.junit.jupiter.api.Test;
 
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+
 /**
  * Tests for the FDFAnnotation class.
  * 
@@ -72,4 +76,46 @@ class FDFAnnotationTest
             assertTrue(testedPDFBox4345andPDFBox3646);
         }
     }
+
+    @Test
+    void testAnnotationWidth() throws IOException
+    {
+        String xfdf =
+            "<?xml version=\"1.0\" encoding=\"UTF-8\"?>" +
+            "<xfdf xmlns=\"http://ns.adobe.com/xfdf/\"; 
xml:space=\"preserve\">" +
+            "<annots>" +
+            "<freetext" +
+            " width=\"0.00\"" +
+            " justification=\"left\" page=\"0\"" +
+            " date=\"D:20251124141013+01'00'\"" +
+            " flags=\"print\"" +
+            " name=\"b525be7e-4735-4598-ab7f-163cd0c7e48b\"" +
+            " rect=\"372.339325,722.633545,531.075317,736.673523\"" +
+            " title=\"Username\"" +
+            " BBox=\"372.339325,722.633545,531.075317,736.673523\"" +
+            " 
Matrix=\"1.000000,0.000000,0.000000,1.000000,0.000000,0.000000\"" +
+            " creationdate=\"D:20251124141003+01'00'\"" +
+            " opacity=\"1\"" +
+            " subject=\"Texteingabe\"" +
+            " intent=\"FreeTextTypewriter\"" +
+            " IT=\"FreeTextTypewriter\">" +
+            "<defaultappearance>&#x20;/Helv 12 Tf 0.415686 0.756863 0.690196 
rg</defaultappearance>" +
+            "<defaultstyle>font: &apos;Helvetica&apos; ,sans-serif 
12.00pt;color:#3049D1</defaultstyle>" +
+            "<contents>Your text is here.</contents>" +
+            "</freetext>" +
+            "</annots>" +
+            "<f href=\".xfdf\"/>" +
+            "</xfdf>";
+
+        ByteArrayInputStream inputStream = new 
ByteArrayInputStream(xfdf.getBytes(StandardCharsets.UTF_8));
+
+        FDFDocument fdfDoc = Loader.loadXFDF(inputStream);
+        List<FDFAnnotation> fdfAnnots = 
fdfDoc.getCatalog().getFDF().getAnnotations();
+        assertEquals(1, fdfAnnots.size());
+
+        FDFAnnotation annot = fdfAnnots.get(0);
+        assertNotNull(annot.getBorderStyle());
+        assertEquals(0f, annot.getBorderStyle().getWidth(), 0.01f);
+    }
+
 }