This is an automated email from the ASF dual-hosted git repository.
asf-gitbox-commits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pdfbox-jbig2.git
The following commit(s) were added to refs/heads/master by this push:
new 2c146e7 PDFBOX-5660: Sonar: modifier ordering; variable declaration
on own line
2c146e7 is described below
commit 2c146e76f481897a17e9bb90d40842591305552c
Author: Maruan Sahyoun <[email protected]>
AuthorDate: Sun May 17 13:32:57 2026 +0200
PDFBOX-5660: Sonar: modifier ordering; variable declaration on own line
---
.../decoder/GenericRefinementRegionDecodingProcedure.java | 15 +++++++++++----
.../decoder/arithmetic/ArithmeticIntegerDecoder.java | 3 ++-
.../apache/pdfbox/jbig2/decoder/huffman/EncodedTable.java | 4 +++-
src/main/java/org/apache/pdfbox/jbig2/image/Bitmaps.java | 3 ++-
src/main/java/org/apache/pdfbox/jbig2/image/Filter.java | 15 ++++++++++-----
.../java/org/apache/pdfbox/jbig2/image/Weighttab.java | 3 ++-
.../org/apache/pdfbox/jbig2/segments/HalftoneRegion.java | 3 ++-
7 files changed, 32 insertions(+), 14 deletions(-)
diff --git
a/src/main/java/org/apache/pdfbox/jbig2/decoder/GenericRefinementRegionDecodingProcedure.java
b/src/main/java/org/apache/pdfbox/jbig2/decoder/GenericRefinementRegionDecodingProcedure.java
index 086e4e7..3c9a744 100644
---
a/src/main/java/org/apache/pdfbox/jbig2/decoder/GenericRefinementRegionDecodingProcedure.java
+++
b/src/main/java/org/apache/pdfbox/jbig2/decoder/GenericRefinementRegionDecodingProcedure.java
@@ -64,7 +64,7 @@ public class GenericRefinementRegionDecodingProcedure
* <p>The two concrete implementations ({@link #T0}, {@link #T1})
correspond
* to GRTEMPLATE values 0 and 1 as defined in §6.3.3 / Figures 14–15.</p>
*/
- public static abstract class Template
+ public abstract static class Template
{
protected abstract short form(short c1, short c2, short c3, short c4,
short c5);
@@ -418,9 +418,16 @@ public class GenericRefinementRegionDecodingProcedure
final int lineOffset, int byteIndex, final int currentLine, int
refByteIndex,
Template templateFormation) throws IOException
{
- short c1, c2, c3, c4, c5;
-
- int w1, w2, w3, w4;
+ short c1;
+ short c2;
+ short c3;
+ short c4;
+ short c5;
+
+ int w1;
+ int w2;
+ int w3;
+ int w4;
w1 = w2 = w3 = w4 = 0;
if (currentLine >= 1 && (currentLine - 1) <
referenceBitmap.getHeight())
diff --git
a/src/main/java/org/apache/pdfbox/jbig2/decoder/arithmetic/ArithmeticIntegerDecoder.java
b/src/main/java/org/apache/pdfbox/jbig2/decoder/arithmetic/ArithmeticIntegerDecoder.java
index 725b668..53f15ce 100644
---
a/src/main/java/org/apache/pdfbox/jbig2/decoder/arithmetic/ArithmeticIntegerDecoder.java
+++
b/src/main/java/org/apache/pdfbox/jbig2/decoder/arithmetic/ArithmeticIntegerDecoder.java
@@ -49,7 +49,8 @@ public class ArithmeticIntegerDecoder
int prev = 1;
int v = 0;
- int d, s;
+ int d;
+ int s;
int bitsToRead;
int offset;
diff --git
a/src/main/java/org/apache/pdfbox/jbig2/decoder/huffman/EncodedTable.java
b/src/main/java/org/apache/pdfbox/jbig2/decoder/huffman/EncodedTable.java
index d0bf8f8..9fb84e0 100644
--- a/src/main/java/org/apache/pdfbox/jbig2/decoder/huffman/EncodedTable.java
+++ b/src/main/java/org/apache/pdfbox/jbig2/decoder/huffman/EncodedTable.java
@@ -45,7 +45,9 @@ public class EncodedTable extends HuffmanTable
List<Code> codeTable = new ArrayList<Code>();
- int prefLen, rangeLen, rangeLow;
+ int prefLen;
+ int rangeLen;
+ int rangeLow;
int curRangeLow = table.getHtLow();
/* Annex B.2 5) - decode table lines */
diff --git a/src/main/java/org/apache/pdfbox/jbig2/image/Bitmaps.java
b/src/main/java/org/apache/pdfbox/jbig2/image/Bitmaps.java
index 32e02e7..d300d37 100644
--- a/src/main/java/org/apache/pdfbox/jbig2/image/Bitmaps.java
+++ b/src/main/java/org/apache/pdfbox/jbig2/image/Bitmaps.java
@@ -538,7 +538,8 @@ public class Bitmaps
int startLine = 0;
int srcStartIdx = 0;
int srcEndIdx = (src.getRowStride() - 1);
- int x1 = x, y1 = y;
+ int x1 = x;
+ int y1 = y;
// Ignore those parts of the source bitmap which would be placed
outside the target bitmap.
if (x < 0)
diff --git a/src/main/java/org/apache/pdfbox/jbig2/image/Filter.java
b/src/main/java/org/apache/pdfbox/jbig2/image/Filter.java
index ff160e9..96ebfba 100644
--- a/src/main/java/org/apache/pdfbox/jbig2/image/Filter.java
+++ b/src/main/java/org/apache/pdfbox/jbig2/image/Filter.java
@@ -99,7 +99,8 @@ abstract class Filter
private double J1(final double x)
{
- double p, q;
+ double p;
+ double q;
int i;
@@ -126,7 +127,8 @@ abstract class Filter
private double P1(final double x)
{
- double p, q;
+ double p;
+ double q;
int i;
@@ -150,7 +152,8 @@ abstract class Filter
private double Q1(final double x)
{
- double p, q;
+ double p;
+ double q;
int i;
@@ -173,7 +176,8 @@ abstract class Filter
private double BesselOrderOne(double x)
{
- double p, q;
+ double p;
+ double q;
if (x == 0.0)
return 0.0;
@@ -379,7 +383,8 @@ abstract class Filter
@Override
public double f(double x)
{
- double b, c;
+ double b;
+ double c;
b = 1.0 / 3.0;
c = 1.0 / 3.0;
diff --git a/src/main/java/org/apache/pdfbox/jbig2/image/Weighttab.java
b/src/main/java/org/apache/pdfbox/jbig2/image/Weighttab.java
index 0dedb98..6263cff 100644
--- a/src/main/java/org/apache/pdfbox/jbig2/image/Weighttab.java
+++ b/src/main/java/org/apache/pdfbox/jbig2/image/Weighttab.java
@@ -25,7 +25,8 @@ import org.apache.pdfbox.jbig2.util.Utils;
final class Weighttab
{
final int[] weights; /* weight[i] goes with pixel at i0+i */
- final int i0, i1; /* range of samples is [i0..i1-1] */
+ final int i0; /* range of samples is [i0..i1-1] */
+ final int i1;
/*
* make_weighttab: sample the continuous filter, scaled by ap.scale and
positioned at continuous source coordinate
diff --git a/src/main/java/org/apache/pdfbox/jbig2/segments/HalftoneRegion.java
b/src/main/java/org/apache/pdfbox/jbig2/segments/HalftoneRegion.java
index 57ba9bd..71ceecd 100644
--- a/src/main/java/org/apache/pdfbox/jbig2/segments/HalftoneRegion.java
+++ b/src/main/java/org/apache/pdfbox/jbig2/segments/HalftoneRegion.java
@@ -200,7 +200,8 @@ public class HalftoneRegion implements Region
*/
private void renderPattern(final int[][] grayScaleValues)
{
- int x = 0, y = 0;
+ int x = 0;
+ int y = 0;
// 1)
for (int m = 0; m < hGridHeight; m++)
