svn commit: r1934352 - pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form

[tilman]

Author: tilman
Date: Mon May 18 11:55:34 2026
New Revision: 1934352

Log:
PDFBOX-5660: improve asserts

Modified:
   
pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java
   
pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDFieldTest.java

Modified: 
pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java
==============================================================================
--- 
pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java
       Mon May 18 11:55:31 2026        (r1934351)
+++ 
pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java
       Mon May 18 11:55:34 2026        (r1934352)
@@ -173,7 +173,7 @@ public class PDChoiceTest
 
             field.setValue("DE");
 
-            assertTrue("The fields value should be set to DE", 
"DE".equals(field.getValue().get(0)));
+            assertEquals("The fields value should be set to DE", "DE", 
field.getValue().get(0));
             
             // Read the content of the normal appearance stream and check that 
it contains the display value for DE
             // which is Deutschland

Modified: 
pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDFieldTest.java
==============================================================================
--- 
pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDFieldTest.java
        Mon May 18 11:55:31 2026        (r1934351)
+++ 
pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDFieldTest.java
        Mon May 18 11:55:34 2026        (r1934352)
@@ -20,6 +20,7 @@ import java.io.IOException;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotEquals;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
@@ -395,14 +396,14 @@ public class PDFieldTest
 
         // Different fields should not be equal
         field2.setPartialName("differentField");
-        assertFalse(field1.equals(field2));
+        assertNotEquals(field1, field2);
 
         // Field should equal itself
         assertEquals(field1, field1);
 
         // Field should not equal null or other types
-        assertFalse(field1.equals(null));
-        assertFalse(field1.equals("not a field"));
+        assertNotNull(field1);
+        assertNotEquals(field1,"not a field");
     }
 
     /**