svn commit: r1935319 - pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel

[tilman]

Author: tilman
Date: Sun Jun 14 19:11:24 2026
New Revision: 1935319

Log:
PDFBOX-5660: Sonar fix

Modified:
   
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocument.java
   
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocumentCatalog.java
   
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPage.java

Modified: 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocument.java
==============================================================================
--- 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocument.java
      Sun Jun 14 18:58:03 2026        (r1935318)
+++ 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocument.java
      Sun Jun 14 19:11:24 2026        (r1935319)
@@ -34,7 +34,6 @@ import static org.junit.jupiter.api.Asse
 import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
-import static org.junit.jupiter.api.Assertions.fail;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
@@ -206,14 +205,8 @@ class TestPDDocument
 
         Loader.loadPDF(f).close();
         
-        try
-        {
-            Files.delete(f.toPath());
-        }
-        catch (IOException ex)
-        {
-            fail("delete good file failed after successful load() and 
close()");
-        }
+        assertDoesNotThrow(() -> Files.delete(f.toPath()), 
+                "delete good file failed after successful load() and close()");
     }
 
     /**
@@ -237,7 +230,7 @@ class TestPDDocument
             doc.save(baos);
         }
 
-        Loader.loadPDF(baos.toByteArray()).close();
+        assertDoesNotThrow(() -> Loader.loadPDF(baos.toByteArray()).close());
 
         Locale.setDefault(defaultLocale);
     }

Modified: 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocumentCatalog.java
==============================================================================
--- 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocumentCatalog.java
       Sun Jun 14 18:58:03 2026        (r1935318)
+++ 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDDocumentCatalog.java
       Sun Jun 14 19:11:24 2026        (r1935319)
@@ -26,6 +26,7 @@ import org.apache.pdfbox.cos.COSName;
 import org.apache.pdfbox.io.RandomAccessReadBuffer;
 import org.apache.pdfbox.pdmodel.graphics.color.PDOutputIntent;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -90,7 +91,7 @@ class TestPDDocumentCatalog
         {
             PDDocumentCatalog cat = doc.getDocumentCatalog();
             // getLabelsByPageIndices() should not throw an exception
-            cat.getPageLabels().getLabelsByPageIndices();
+            assertDoesNotThrow(() -> 
cat.getPageLabels().getLabelsByPageIndices());
         }
     }
 

Modified: 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPage.java
==============================================================================
--- 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPage.java
  Sun Jun 14 18:58:03 2026        (r1935318)
+++ 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPage.java
  Sun Jun 14 19:11:24 2026        (r1935319)
@@ -24,6 +24,7 @@ import org.apache.pdfbox.pdmodel.common.
 import org.apache.pdfbox.pdmodel.interactive.annotation.PDAnnotationWidget;
 import org.apache.pdfbox.pdmodel.interactive.form.PDAcroForm;
 import org.apache.pdfbox.pdmodel.interactive.form.PDTextField;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 import org.junit.jupiter.api.Test;
@@ -51,7 +52,7 @@ class TestPDPage
             acroForm.getFields().add(textField);
 
             // Adding page AFTER creating form fields causes StackOverflowError
-            document.addPage(page);
+            assertDoesNotThrow(() -> document.addPage(page));
 
             document.save(new ByteArrayOutputStream());
             document.close();