svn commit: r1936433 - in pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel: . interactive/form

[tilman]

Author: tilman
Date: Tue Jul 21 18:57:25 2026
New Revision: 1936433

Log:
PDFBOX-5660: remove double close as suggested by Valery Bokov; use assume; 
closes #486

Modified:
   pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPage.java
   
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java

Modified: 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPage.java
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPage.java 
Tue Jul 21 18:57:21 2026        (r1936432)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/TestPDPage.java 
Tue Jul 21 18:57:25 2026        (r1936433)
@@ -55,7 +55,6 @@ class TestPDPage
             assertDoesNotThrow(() -> document.addPage(page));
 
             document.save(OutputStream.nullOutputStream());
-            document.close();
         }
     }
     

Modified: 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java
      Tue Jul 21 18:57:21 2026        (r1936432)
+++ 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java
      Tue Jul 21 18:57:25 2026        (r1936433)
@@ -19,6 +19,7 @@ package org.apache.pdfbox.pdmodel.intera
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assumptions.assumeTrue;
 
 import java.io.File;
 import java.io.IOException;
@@ -157,10 +158,7 @@ class PDChoiceTest
     {
         File pdfFile = new File("target/pdfs/PDFBOX-6150.pdf");
         
-        if (!pdfFile.exists())
-        {
-            return;  // Skip test if PDF not available
-        }
+        assumeTrue(pdfFile.exists()); // Skip test if PDF not available
 
         // Load document, set value, and save to memory
         try (PDDocument document = Loader.loadPDF(pdfFile))
@@ -177,8 +175,6 @@ class PDChoiceTest
             List<String> content = TestUtils.getStringsFromStream(field);
             boolean hasContent = 
content.stream().anyMatch("Deutschland"::equals);
             assertTrue(hasContent, "The content should contain the display 
value for DE which is Deutschland");
-            
-            document.close();
         }
     }
 }