svn commit: r1937618 - pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf

[tilman]

Author: tilman
Date: Sat Aug 29 14:23:37 2026
New Revision: 1937618

Log:
PDFBOX-5660: DRY refactoring

Modified:
   pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/TTFParser.java

Modified: 
pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/TTFParser.java
==============================================================================
--- pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/TTFParser.java    
Sat Aug 29 12:31:14 2026        (r1937617)
+++ pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/TTFParser.java    
Sat Aug 29 14:23:37 2026        (r1937618)
@@ -16,6 +16,7 @@
  */
 package org.apache.fontbox.ttf;
 
+import java.io.Closeable;
 import java.io.IOException;
 import java.io.InputStream;
 
@@ -62,17 +63,7 @@ public class TTFParser
      */
     public TrueTypeFont parse(RandomAccessRead randomAccessRead) throws 
IOException
     {
-        RandomAccessReadDataStream dataStream = new 
RandomAccessReadDataStream(randomAccessRead);
-        try (randomAccessRead)
-        {
-            return parse(dataStream);
-        }
-        catch (IOException ex)
-        {
-            // close only on error (source is still being accessed later)
-            dataStream.close();
-            throw ex;
-        }
+        return parse(randomAccessRead, new 
RandomAccessReadDataStream(randomAccessRead));
     }
 
     /**
@@ -85,8 +76,13 @@ public class TTFParser
     public TrueTypeFont parseEmbedded(InputStream inputStream) throws 
IOException
     {
         this.isEmbedded = true;
-        RandomAccessReadDataStream dataStream = new 
RandomAccessReadDataStream(inputStream);
-        try (inputStream)
+        return parse(inputStream, new RandomAccessReadDataStream(inputStream));
+    }
+
+    private TrueTypeFont parse(Closeable input, RandomAccessReadDataStream 
dataStream)
+            throws IOException
+    {
+        try (input)
         {
             return parse(dataStream);
         }