svn commit: r1937686 - pdfbox/branches/3.0/fontbox/src/test/java/org/apache/fontbox/ttf

[tilman]

Author: tilman
Date: Mon Aug 31 12:12:19 2026
New Revision: 1937686

Log:
PDFBOX-5660: improve test coverage

Modified:
   
pdfbox/branches/3.0/fontbox/src/test/java/org/apache/fontbox/ttf/TrueTypeFontCollectionTest.java

Modified: 
pdfbox/branches/3.0/fontbox/src/test/java/org/apache/fontbox/ttf/TrueTypeFontCollectionTest.java
==============================================================================
--- 
pdfbox/branches/3.0/fontbox/src/test/java/org/apache/fontbox/ttf/TrueTypeFontCollectionTest.java
    Mon Aug 31 12:12:16 2026        (r1937685)
+++ 
pdfbox/branches/3.0/fontbox/src/test/java/org/apache/fontbox/ttf/TrueTypeFontCollectionTest.java
    Mon Aug 31 12:12:19 2026        (r1937686)
@@ -19,19 +19,105 @@ package org.apache.fontbox.ttf;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
 import java.io.ByteArrayInputStream;
+import java.io.File;
 import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assumptions.assumeTrue;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.condition.EnabledOnOs;
+import org.junit.jupiter.api.condition.OS;
 
 class TrueTypeFontCollectionTest
 {
     @Test
+    void testMissingTtcHeader()
+    {
+        IOException ex = assertThrows(IOException.class,
+                () -> new TrueTypeCollection(new ByteArrayInputStream(new 
byte[4])),
+                "Missing ttc header not detected!");
+        assertEquals("Missing TTC header", ex.getMessage());
+    }
+
+    @Test
     void testNumberOfFonts()
     {
         byte[] payload = { 0x74, 0x74, 0x63, 0x66, 0x00, 0x00, 0x00, 0x00, 
0x7F, (byte) 0xFF,
                 (byte) 0xFF, (byte) 0xFF };
-        assertThrows(IOException.class,
+        IOException ex = assertThrows(IOException.class,
                 () -> new TrueTypeCollection(new 
ByteArrayInputStream(payload)),
                 "Invalid number of fonts not detected!");
+        assertEquals("Invalid number of fonts 2147483647", ex.getMessage());
+    }
+
+    @Test
+    @EnabledOnOs(OS.WINDOWS)
+    void testMingLiu() throws IOException
+    {
+        File file = new File("c:/windows/fonts/mingliu.ttc");
+        assumeTrue(file.exists());
+        checkTrueTypeCollection(file, "[MingLiU, PMingLiU, 
Ming-Lt-HKSCS-UNI-H]");
+    }
+
+    @Test
+    @EnabledOnOs(OS.WINDOWS)
+    void testMsMincho() throws IOException
+    {
+        File file = new File("c:/windows/fonts/msmincho.ttc");
+        assumeTrue(file.exists());
+        checkTrueTypeCollection(file, "[MS-Mincho, MS-PMincho]");
+    }
+
+    @Test
+    @EnabledOnOs(OS.WINDOWS)
+    void testSimSun() throws IOException
+    {
+        File file = new File("c:/windows/fonts/simsun.ttc");
+        assumeTrue(file.exists());
+        checkTrueTypeCollection(file, "[SimSun, NSimSun]");
+    }
+
+    @Test
+    @EnabledOnOs(OS.MAC)
+    void testLucidaGrande() throws IOException
+    {
+        File file = new File("/System/Library/Fonts/LucidaGrande.ttc");
+        assumeTrue(file.exists());
+        checkTrueTypeCollection(file, "[LucidaGrande, LucidaGrande-Bold, 
.LucidaGrandeUI, .LucidaGrandeUI-Bold]");
+    }
+
+    @Test
+    @EnabledOnOs(OS.MAC)
+    void testAvenir() throws IOException
+    {
+        File file = new File("/System/Library/Fonts/Avenir.ttc");
+        assumeTrue(file.exists());
+        checkTrueTypeCollection(file, 
+                "[Avenir-Book, Avenir-BookOblique, Avenir-Black, 
Avenir-BlackOblique, "
+                        + "Avenir-Heavy, Avenir-HeavyOblique, Avenir-Light, 
Avenir-LightOblique, "
+                        + "Avenir-Medium, Avenir-MediumOblique, 
Avenir-Oblique, Avenir-Roman]");
+    }
+
+    private void checkTrueTypeCollection(File file, String expected) throws 
IOException
+    {
+        try (TrueTypeCollection ttc = new TrueTypeCollection(file))
+        {
+            List<String> list = new ArrayList();
+            ttc.processAllFonts((TrueTypeFont ttf) ->
+            {
+                list.add(ttf.getName());
+                try (TrueTypeFont ttfByName = ttc.getFontByName(ttf.getName()))
+                {
+                    assertEquals(ttf.getName(), ttfByName.getName());
+                }
+            });
+            assertEquals(expected, list.toString());
+        }
+        List<String> list = new ArrayList();
+        TrueTypeCollection.processAllFontHeaders(file, fontHeaders -> 
list.add(fontHeaders.getName()));
+        assertEquals(expected, list.toString());
     }
 }