This is an automated email from the ASF dual-hosted git repository.

wangdan pushed a commit to branch v2.4
in repository https://gitbox.apache.org/repos/asf/incubator-pegasus.git


The following commit(s) were added to refs/heads/v2.4 by this push:
     new d404314b3 fix: fix rocksdb build type (cherry-pick #1340) (#1775)
d404314b3 is described below

commit d404314b3bbacd6e67891bb735abd1e8cac56367
Author: Dan Wang <[email protected]>
AuthorDate: Fri Dec 15 18:15:16 2023 +0800

    fix: fix rocksdb build type (cherry-pick #1340) (#1775)
    
    https://github.com/apache/incubator-pegasus/issues/1339
    
    RocksDB library is not built in Release version, which may cause terrible 
performance issues.
    
    This PR is to cherry-pick #1340 into v2.4 to resolve #1339.
---
 thirdparty/CMakeLists.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/thirdparty/CMakeLists.txt b/thirdparty/CMakeLists.txt
index 007fee11f..87ddba72e 100644
--- a/thirdparty/CMakeLists.txt
+++ b/thirdparty/CMakeLists.txt
@@ -401,6 +401,7 @@ ExternalProject_Add(rocksdb
         -DWITH_TESTS=OFF
         -DWITH_GFLAGS=OFF
         -DUSE_RTTI=ON
+        -DCMAKE_BUILD_TYPE=Release
         -DWITH_JEMALLOC=${USE_JEMALLOC}
         -DJEMALLOC_ROOT_DIR=${TP_OUTPUT}
         -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to