This is an automated email from the ASF dual-hosted git repository.
laiyingchun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pegasus.git
The following commit(s) were added to refs/heads/master by this push:
new ebb74e038 chore(CI): Sort disabled clang-tidy checks option (#2117)
ebb74e038 is described below
commit ebb74e038ff255cdc856663e7c278743bc8c323b
Author: Yingchun Lai <[email protected]>
AuthorDate: Wed Sep 18 13:33:43 2024 +0800
chore(CI): Sort disabled clang-tidy checks option (#2117)
---
.clang-tidy | 4 +++-
build_tools/clang_tidy.py | 35 ++++++++++++++++++++++++++++++++++-
2 files changed, 37 insertions(+), 2 deletions(-)
diff --git a/.clang-tidy b/.clang-tidy
index 20ca366c0..888e91b95 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -18,7 +18,9 @@
#
https://releases.llvm.org/14.0.0/tools/clang/tools/extra/docs/clang-tidy/index.html
CheckOptions: []
-Checks:
'abseil-*,boost-*,bugprone-*,cert-*,clang-analyzer-*,concurrency-*,cppcoreguidelines-*,darwin-*,fuchsia-*,google-*,hicpp-*,linuxkernel-*,llvm-*,misc-*,modernize-*,performance-*,portability-*,readability-*,-cppcoreguidelines-pro-type-union-access,-llvm-include-order,-misc-definitions-in-headers,-modernize-use-trailing-return-type,-cppcoreguidelines-macro-usage,-modernize-replace-disallow-copy-and-assign-macro,-bugprone-macro-parentheses,-cppcoreguidelines-avoid-non-const-global-va
[...]
+# Disable some checks that are not useful for us now.
+# They are sorted by names, and should be consistent to
build_tools/clang_tidy.py.
+Checks:
'abseil-*,boost-*,bugprone-*,cert-*,clang-analyzer-*,concurrency-*,cppcoreguidelines-*,darwin-*,fuchsia-*,google-*,hicpp-*,linuxkernel-*,llvm-*,misc-*,modernize-*,performance-*,portability-*,readability-*,-bugprone-easily-swappable-parameters,-bugprone-lambda-function-name,-bugprone-macro-parentheses,-cert-err58-cpp,-concurrency-mt-unsafe,-cppcoreguidelines-avoid-c-arrays,-cppcoreguidelines-avoid-magic-numbers,-cppcoreguidelines-avoid-non-const-global-variables,-cppcoreguidelines
[...]
ExtraArgs:
ExtraArgsBefore: []
FormatStyle: none
diff --git a/build_tools/clang_tidy.py b/build_tools/clang_tidy.py
index 2c3645d08..b2ef72d9b 100755
--- a/build_tools/clang_tidy.py
+++ b/build_tools/clang_tidy.py
@@ -60,7 +60,40 @@ def run_tidy(sha="HEAD", is_rev_range=False):
"clang-tidy",
"-p0",
"-path", BUILD_PATH,
-
"-checks=-cppcoreguidelines-pro-type-union-access,-llvm-include-order,-misc-definitions-in-headers,-modernize-use-trailing-return-type,-cppcoreguidelines-macro-usage,-modernize-replace-disallow-copy-and-assign-macro,-bugprone-macro-parentheses,-cppcoreguidelines-avoid-non-const-global-variables,-fuchsia-statically-constructed-objects,-fuchsia-overloaded-operator,-bugprone-easily-swappable-parameters,-cppcoreguidelines-non-private-member-variables-in-classes,-misc-non-p
[...]
+ # Disable some checks that are not useful for us now.
+ # They are sorted by names, and should be consistent to
.clang-tidy.
+ "-checks=-bugprone-easily-swappable-parameters,"
+ "-bugprone-lambda-function-name,"
+ "-bugprone-macro-parentheses,"
+ "-cert-err58-cpp,"
+ "-concurrency-mt-unsafe,"
+ "-cppcoreguidelines-avoid-c-arrays,"
+ "-cppcoreguidelines-avoid-magic-numbers,"
+
"-cppcoreguidelines-avoid-non-const-global-variables,"
+ "-cppcoreguidelines-macro-usage,"
+
"-cppcoreguidelines-non-private-member-variables-in-classes,"
+ "-cppcoreguidelines-owning-memory,"
+
"-cppcoreguidelines-pro-bounds-array-to-pointer-decay,"
+ "-cppcoreguidelines-pro-bounds-pointer-arithmetic,"
+ "-cppcoreguidelines-pro-type-const-cast,"
+ "-cppcoreguidelines-pro-type-union-access,"
+ "-fuchsia-default-arguments-calls,"
+ "-fuchsia-overloaded-operator,"
+ "-fuchsia-statically-constructed-objects,"
+
"-google-readability-avoid-underscore-in-googletest-name,"
+ "-hicpp-avoid-c-arrays,"
+ "-hicpp-named-parameter,"
+ "-hicpp-no-array-decay,"
+ "-llvm-include-order,"
+ "-misc-definitions-in-headers,"
+ "-misc-non-private-member-variables-in-classes,"
+ "-modernize-avoid-c-arrays,"
+ "-modernize-replace-disallow-copy-and-assign-macro,"
+ "-modernize-use-trailing-return-type,"
+ "-readability-function-cognitive-complexity,"
+ "-readability-identifier-length,"
+ "-readability-magic-numbers,"
+ "-readability-named-parameter",
"-extra-arg=-language=c++",
"-extra-arg=-std=c++17",
"-extra-arg=-Ithirdparty/output/include"]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
