This is an automated email from the ASF dual-hosted git repository.
fanningpj pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-pekko.git
The following commit(s) were added to refs/heads/main by this push:
new e365e44aea add link to CLA page (#97)
e365e44aea is described below
commit e365e44aea0d23b89144c1caee5bfd5c0d273808
Author: PJ Fanning <[email protected]>
AuthorDate: Wed Jan 11 17:47:58 2023 +0100
add link to CLA page (#97)
* add link to CLA page
* Update CONTRIBUTING.md
---
CONTRIBUTING.md | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 8cdf5c91a8..09cc9ad9d2 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -74,6 +74,7 @@ The steps are exactly the same for everyone involved in the
project, including t
1. Now it's finally time to [submit the pull
request](https://help.github.com/articles/using-pull-requests)!
- Please make sure to include a reference to the issue you're solving *in
the comment* for the Pull Request, as this will cause the PR to be linked
properly with the issue. Examples of good phrases for this are: "Resolves
#1234" or "Refs #1234".
1. If you are a first time contributor, a core member must approve the CI to
run for your pull request.
+1. For non-trivial changes, you will be asked to sign the
[CLA](https://www.apache.org/licenses/contributor-agreements.html) if you have
not done so before.
1. Now, both committers and interested people will review your code. This
process ensures that the code we merge is of the best possible quality and that
no silly mistakes slip through. You're expected to follow-up on these comments
by adding new commits to the same branch. The commit messages of those commits
can be more loose, for example: `Removed debugging using printline`, as they
all will be squashed into one commit before merging into the main branch.
- The community and core team are really nice people, so don't be afraid
to ask follow-up questions if you didn't understand some comment or would like
clarification on how to continue with a given feature. We're here to help, so
feel free to ask and discuss any questions you might have during the review
process!
1. After the review, you should fix the issues as needed (pushing a new commit
for a new review, etc.), iterating until the reviewers give their approval
signaled by GitHub's pull-request approval feature. Usually, a reviewer will
add an `LGTM` comment, which means "Looks Good To Me".
@@ -88,7 +89,7 @@ The TL;DR; of the above very precise workflow version is:
2. Hack and test on your feature (on a branch)
3. Document it
4. Submit a PR
-5. Sign the CLA if necessary
+5. Sign the [CLA](https://www.apache.org/licenses/contributor-agreements.html)
if necessary
6. Keep polishing it until getting the required number of approvals
7. Profit!
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
