This is an automated email from the ASF dual-hosted git repository.
mdedetrich pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-pekko-grpc.git
The following commit(s) were added to refs/heads/main by this push:
new 952bb33a Add in TODOs for future code revisions
952bb33a is described below
commit 952bb33a6c053ca01b4e39812a00ff203f547938
Author: Matthew de Detrich <[email protected]>
AuthorDate: Mon Apr 17 09:12:22 2023 +0200
Add in TODOs for future code revisions
---
build.sbt | 2 +-
plugin-tester-java/build.gradle | 2 +-
plugin-tester-java/pom.xml | 2 +-
plugin-tester-scala/build.gradle | 2 +-
plugin-tester-scala/pom.xml | 2 +-
project/Dependencies.scala | 4 ++--
6 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/build.sbt b/build.sbt
index 7078d752..1d955537 100644
--- a/build.sbt
+++ b/build.sbt
@@ -16,7 +16,7 @@ lazy val mkBatAssemblyTask = taskKey[File]("Create a Windows
bat assembly")
(ThisBuild / dynverSeparator) := "-"
ThisBuild / resolvers += "Apache
Snapshots".at("https://repository.apache.org/content/repositories/snapshots/";)
-ThisBuild / resolvers ++= Resolver.sonatypeOssRepos("snapshot") // Remove when
proper release of pekko-http-cors is made
+ThisBuild / resolvers ++= Resolver.sonatypeOssRepos("snapshot") // TODO Remove
when proper release of pekko-http-cors is made
val pekkoGrpcCodegenId = s"$pekkoPrefix-codegen"
lazy val codegen = Project(id = "codegen", base = file("codegen"))
diff --git a/plugin-tester-java/build.gradle b/plugin-tester-java/build.gradle
index ea8af879..1c3aa691 100644
--- a/plugin-tester-java/build.gradle
+++ b/plugin-tester-java/build.gradle
@@ -13,7 +13,7 @@ pekkoGrpc {
repositories {
mavenLocal()
- maven { url 'https://oss.sonatype.org/content/repositories/snapshots/' } //
Remove when proper release of pekko-http-cors is made
+ maven { url 'https://oss.sonatype.org/content/repositories/snapshots/' } //
TODO Remove when proper release of pekko-http-cors is made
}
def scalaFullVersion = "2.12.17"
diff --git a/plugin-tester-java/pom.xml b/plugin-tester-java/pom.xml
index c0e799e6..2fbc9e4a 100644
--- a/plugin-tester-java/pom.xml
+++ b/plugin-tester-java/pom.xml
@@ -26,7 +26,7 @@
<name>Apache Snapshots Repository</name>
<url>https://repository.apache.org/content/repositories/snapshots/</url>
</repository>
- <!-- Remove when proper release of pekko-http-cors is made -->
+ <!-- TODO Remove when proper release of pekko-http-cors is made -->
<repository>
<id>sonatype-snapshots</id>
<name>Sonatype Snapshots Repository</name>
diff --git a/plugin-tester-scala/build.gradle b/plugin-tester-scala/build.gradle
index 9a22743d..e2db96be 100644
--- a/plugin-tester-scala/build.gradle
+++ b/plugin-tester-scala/build.gradle
@@ -8,7 +8,7 @@ pekkoGrpc {
repositories {
mavenLocal()
- maven { url 'https://oss.sonatype.org/content/repositories/snapshots/' } //
Remove when proper release of pekko-http-cors is made
+ maven { url 'https://oss.sonatype.org/content/repositories/snapshots/' } //
TODO Remove when proper release of pekko-http-cors is made
}
def scalaFullVersion = "2.12.17"
diff --git a/plugin-tester-scala/pom.xml b/plugin-tester-scala/pom.xml
index a1222ce8..6148dd59 100644
--- a/plugin-tester-scala/pom.xml
+++ b/plugin-tester-scala/pom.xml
@@ -25,7 +25,7 @@
<name>Apache Snapshots Repository</name>
<url>https://repository.apache.org/content/repositories/snapshots/</url>
</repository>
- <!-- Remove when proper release of pekko-http-cors is made -->
+ <!-- TODO Remove when proper release of pekko-http-cors is made -->
<repository>
<id>sonatype-snapshots</id>
<name>Sonatype Snapshots Repository</name>
diff --git a/project/Dependencies.scala b/project/Dependencies.scala
index 37297231..18e44532 100644
--- a/project/Dependencies.scala
+++ b/project/Dependencies.scala
@@ -114,7 +114,7 @@ object Dependencies {
Compile.pekkoHttpCore,
Compile.pekkoHttp,
Compile.pekkoDiscovery,
- // Remove exclusion rule when proper release of pekko-http-cors is made
+ // TODO Remove exclusion rule when proper release of pekko-http-cors is
made
(Compile.pekkoHttpCors % "provided").excludeAll(
"org.apache.pekko" %% "pekko-http"),
Compile.pekkoHttp % "provided",
@@ -150,7 +150,7 @@ object Dependencies {
val pluginTester = l ++= Seq(
// usually automatically added by `suggestedDependencies`, which doesn't
work with ReflectiveCodeGen
Compile.grpcStub,
- // Remove exclusion rule when proper release of pekko-http-cors is made
+ // TODO Remove exclusion rule when proper release of pekko-http-cors is
made
Compile.pekkoHttpCors.excludeAll(
"org.apache.pekko" %% "pekko-http"),
Compile.pekkoHttp,
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
