This is an automated email from the ASF dual-hosted git repository.
fanningpj pushed a commit to branch 1.0.x
in repository https://gitbox.apache.org/repos/asf/incubator-pekko.git
The following commit(s) were added to refs/heads/1.0.x by this push:
new a565ac49f0 Remove note about Lagom (#698) (#699)
a565ac49f0 is described below
commit a565ac49f0bc0e9198a111ab6257956c105edbd5
Author: PJ Fanning <[email protected]>
AuthorDate: Mon Oct 9 18:37:49 2023 +0100
Remove note about Lagom (#698) (#699)
* Remove note about Lagom
* Update PersistenceId.scala
---
docs/src/main/paradox/typed/persistence.md | 8 -------
.../pekko/persistence/typed/PersistenceId.scala | 26 ++++------------------
2 files changed, 4 insertions(+), 30 deletions(-)
diff --git a/docs/src/main/paradox/typed/persistence.md
b/docs/src/main/paradox/typed/persistence.md
index a3afe529eb..3a6fdfd57f 100644
--- a/docs/src/main/paradox/typed/persistence.md
+++ b/docs/src/main/paradox/typed/persistence.md
@@ -119,14 +119,6 @@ to help with constructing such `PersistenceId` from an
`entityTypeHint` and `ent
The default separator when concatenating the `entityTypeHint` and `entityId`
is `|`, but a custom separator
is supported.
-@@@ note
-
-The `|` separator is also used in Lagom's `scaladsl.PersistentEntity` but no
separator is used
-in Lagom's `javadsl.PersistentEntity`. For compatibility with Lagom's
`javadsl.PersistentEntity`
-you should use `""` as the separator.
-
-@@@
-
A custom identifier can be created with
@apidoc[PersistenceId.ofUniqueId](typed.PersistenceId$)
{scala="#ofUniqueId(id:String):org.apache.pekko.persistence.typed.PersistenceId"
java="#ofUniqueId(java.lang.String)"}.
### Command handler
diff --git
a/persistence-typed/src/main/scala/org/apache/pekko/persistence/typed/PersistenceId.scala
b/persistence-typed/src/main/scala/org/apache/pekko/persistence/typed/PersistenceId.scala
index 6b0113e8f8..8eb0a95d25 100644
---
a/persistence-typed/src/main/scala/org/apache/pekko/persistence/typed/PersistenceId.scala
+++
b/persistence-typed/src/main/scala/org/apache/pekko/persistence/typed/PersistenceId.scala
@@ -17,8 +17,6 @@ object PersistenceId {
/**
* Default separator character used for concatenating a `typeHint` with
`entityId` to construct unique persistenceId.
- * This must be same as in Lagom's `scaladsl.PersistentEntity`, for
compatibility. No separator is used
- * in Lagom's `javadsl.PersistentEntity` so for compatibility with that the
`""` separator must be used instead.
*/
val DefaultSeparator = "|"
@@ -37,11 +35,7 @@ object PersistenceId {
*
* Another separator can be defined by using the `apply` that takes a
`separator` parameter.
*
- * The `|` separator is also used in Lagom's `scaladsl.PersistentEntity` but
no separator is used
- * in Lagom's `javadsl.PersistentEntity`. For compatibility with Lagom's
`javadsl.PersistentEntity`
- * you should use `""` as the separator.
- *
- * @throws IllegalArgumentException if the `entityTypeHint` or `entityId`
contains `|`
+ * @throws java.lang.IllegalArgumentException if the `entityTypeHint` or
`entityId` contains `|`
*/
def apply(entityTypeHint: String, entityId: String): PersistenceId =
apply(entityTypeHint, entityId, DefaultSeparator)
@@ -61,11 +55,7 @@ object PersistenceId {
*
* The default separator `|` is used by the `apply` that doesn't take a
`separator` parameter.
*
- * The `|` separator is also used in Lagom's `scaladsl.PersistentEntity` but
no separator is used
- * in Lagom's `javadsl.PersistentEntity`. For compatibility with Lagom's
`javadsl.PersistentEntity`
- * you should use `""` as the separator.
- *
- * @throws IllegalArgumentException if the `entityTypeHint` or `entityId`
contains `separator`
+ * @throws java.lang.IllegalArgumentException if the `entityTypeHint` or
`entityId` contains `separator`
*/
def apply(entityTypeHint: String, entityId: String, separator: String):
PersistenceId = {
if (separator.nonEmpty) {
@@ -95,11 +85,7 @@ object PersistenceId {
*
* Another separator can be defined by using the `PersistenceId.of` that
takes a `separator` parameter.
*
- * The `|` separator is also used in Lagom's `scaladsl.PersistentEntity` but
no separator is used
- * in Lagom's `javadsl.PersistentEntity`. For compatibility with Lagom's
`javadsl.PersistentEntity`
- * you should use `""` as the separator.
- *
- * @throws IllegalArgumentException if the `entityTypeHint` or `entityId`
contains `|`
+ * @throws java.lang.IllegalArgumentException if the `entityTypeHint` or
`entityId` contains `|`
*/
def of(entityTypeHint: String, entityId: String): PersistenceId =
apply(entityTypeHint, entityId)
@@ -119,11 +105,7 @@ object PersistenceId {
*
* The default separator `|` is used by the `apply` that doesn't take a
`separator` parameter.
*
- * The `|` separator is also used in Lagom's `scaladsl.PersistentEntity` but
no separator is used
- * in Lagom's `javadsl.PersistentEntity`. For compatibility with Lagom's
`javadsl.PersistentEntity`
- * you should use `""` as the separator.
- *
- * @throws IllegalArgumentException if the `entityTypeHint` or `entityId`
contains `separator`
+ * @throws java.lang.IllegalArgumentException if the `entityTypeHint` or
`entityId` contains `separator`
*/
def of(entityTypeHint: String, entityId: String, separator: String):
PersistenceId =
apply(entityTypeHint, entityId, separator)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
