This is an automated email from the ASF dual-hosted git repository.
fanningpj pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pekko.git
The following commit(s) were added to refs/heads/main by this push:
new 0d36a6f928 Update converter references in CONTRIBUTING.md (#2293)
0d36a6f928 is described below
commit 0d36a6f928457f74afd37b4554cdcd263fb16969
Author: PJ Fanning <[email protected]>
AuthorDate: Thu Oct 2 17:28:49 2025 +0100
Update converter references in CONTRIBUTING.md (#2293)
Clarified usage of converters in Scala to Java API interactions.
---
CONTRIBUTING.md | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 1d8740561b..54fd07904b 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -529,12 +529,14 @@ Scala has proven the most viable way to do it, as long as
you keep the following
1. If the underlying Scala code requires an `ExecutionContext`, make the Java
API take an `Executor` and use
`ExecutionContext.fromExecutor(executor)` for conversion.
-1. Use `scala.jdk.FutureConverters` to translate `Future`s to
`CompletionStage`s (or vice versa).
+1. Use `scala.jdk.FutureConverters` or `scala.jdk.javaapi.FutureConverters` to
translate `Future`s to `CompletionStage`s (or vice versa).
-1. Use `scala.jdk.javaapi.OptionConverters` to translate `Option`s to Java
`Optional`s (or vice versa).
+1. Use `scala.jdk.OptionConverters` or `scala.jdk.javaapi.OptionConverters` to
translate `Option`s to Java `Optional`s (or vice versa).
-1. Use `scala.jdk.javapi.FunctionConverters` to translate Scala Functions to
Java Functions (or vice versa).
+1. Use `scala.jdk.FunctionConverters` or
`scala.jdk.javaapi.FunctionConverters` to translate Scala Functions to Java
Functions (or vice versa).
+1. Use `scala.jdk.DurationConverters` or
`scala.jdk.javaapi.DurationConverters` to translate Scala `Duration`s to
`java.time.Duration`s (or vice versa).
+
1. Make sure there are Java tests or sample code touching all parts of the API
1. Do not use lower type bounds: `trait[T] { def method[U >: Something]: U }`
as they do not work with Java
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]