This is an automated email from the ASF dual-hosted git repository.
He-Pin pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pekko.git
The following commit(s) were added to refs/heads/main by this push:
new 02a730ad28 chore: adjust snapshot retention warning (#2953)
02a730ad28 is described below
commit 02a730ad289554ffffe912bb5a6e2973e7769907
Author: He-Pin(kerr) <[email protected]>
AuthorDate: Sat May 9 23:32:02 2026 +0800
chore: adjust snapshot retention warning (#2953)
Motivation:
Upstream commit
https://github.com/akka/akka-core/commit/c8d9fb3e46cca930186d72de66100acf29b850fd,
which is now Apache licensed, adjusted the wording of the snapshot retention
warning.
Modification:
Align the warning text so the sentence has the intended spacing and no
longer includes the snapshot store id placeholder.
Result:
The warning is clearer while behavior remains unchanged.
Tests:
- git diff --check / passed
- scalafmt --mode diff-ref=origin/main / passed
- scalafmt --list --mode diff-ref=origin/main / passed
- sbt "persistence-typed / Test / compile" / passed
References:
Refs
https://github.com/akka/akka-core/commit/c8d9fb3e46cca930186d72de66100acf29b850fd
Co-authored-by: Copilot <[email protected]>
---
.../apache/pekko/persistence/typed/internal/BehaviorSetup.scala | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
a/persistence-typed/src/main/scala/org/apache/pekko/persistence/typed/internal/BehaviorSetup.scala
b/persistence-typed/src/main/scala/org/apache/pekko/persistence/typed/internal/BehaviorSetup.scala
index f8670c5bc1..53564c2607 100644
---
a/persistence-typed/src/main/scala/org/apache/pekko/persistence/typed/internal/BehaviorSetup.scala
+++
b/persistence-typed/src/main/scala/org/apache/pekko/persistence/typed/internal/BehaviorSetup.scala
@@ -113,12 +113,11 @@ private[pekko] final class BehaviorSetup[C, E, S](
case SnapshotCountRetentionCriteriaImpl(_, keepNSnapshots, _) if
keepNSnapshots > 1 =>
// not using internalLogger because it's probably not good to use mdc
from the constructor
internalLoggerFactory().warn(
- "Retention has been defined with keepNSnapshots [{}] for
persistenceId [{}]," +
- "but the snapshot store [{}] will only keep one snapshot. You can
silence this warning and benefit from " +
+ "Retention has been defined with keepNSnapshots [{}] for
persistenceId [{}], " +
+ "but the snapshot store will only keep one snapshot. You can silence
this warning and benefit from " +
"a performance optimization by defining the retention criteria
without the keepNSnapshots parameter.",
keepNSnapshots,
- persistenceId,
- settings.snapshotPluginId)
+ persistenceId)
case _ =>
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
