This is an automated email from the ASF dual-hosted git repository.
He-Pin pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pekko-connectors-kafka.git
The following commit(s) were added to refs/heads/main by this push:
new ab9e1da8 chore: unify formatter config - standardize aliases, add
JDK17 setting (#548)
ab9e1da8 is described below
commit ab9e1da88524b42d62e5b9de7bb06e90b6597ebf
Author: He-Pin(kerr) <[email protected]>
AuthorDate: Mon Jun 15 17:12:41 2026 +0800
chore: unify formatter config - standardize aliases, add JDK17 setting
(#548)
* chore: unify formatter config across pekko sub-projects
Motivation:
Align formatter plugins, command aliases, and JDK settings with other
pekko sub-projects to reduce maintenance burden.
Modification:
- Standardize checkCodeStyle/applyCodeStyle command aliases
- Add ThisBuild / javafmtFormatterCompatibleJavaVersion := 17 where missing
- Replace custom verifyCodeFmt tasks with standard aliases where applicable
- Upgrade sbt-java-formatter plugin where needed
Result:
Consistent formatter configuration across all pekko sub-projects.
Tests:
Not run - build config change only
References:
None - formatter unification across pekko sub-projects
* fix: use checkCodeStyle alias in CI and standardize build.sbt aliases
Motivation:
CI was only running javafmtCheckAll, missing scalafmt and header checks.
Build.sbt aliases used non-standard ordering.
Modification:
- CI: replace javafmtCheckAll with checkCodeStyle
- build.sbt: standardize checkCodeStyle and applyCodeStyle alias order
Result:
CI runs full code style check; aliases consistent with other pekko projects.
---
.github/workflows/check-build-test.yml | 4 ++--
build.sbt | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/check-build-test.yml
b/.github/workflows/check-build-test.yml
index fa642bfb..a8d48693 100644
--- a/.github/workflows/check-build-test.yml
+++ b/.github/workflows/check-build-test.yml
@@ -48,8 +48,8 @@ jobs:
uses: sbt/setup-sbt@af116cce31c00823d3903ce687f9cda3a4f19f1b # v1.2.1
- name: Code style check and binary-compatibility check
- # Run locally with: sbt 'javafmtCheckAll; mimaReportBinaryIssues'
- run: sbt "javafmtCheckAll; mimaReportBinaryIssues"
+ # Run locally with: sbt 'checkCodeStyle; mimaReportBinaryIssues'
+ run: sbt "checkCodeStyle; mimaReportBinaryIssues"
check-code-compilation:
name: Check Code Compilation
diff --git a/build.sbt b/build.sbt
index 7b977721..d8b9ad0a 100644
--- a/build.sbt
+++ b/build.sbt
@@ -18,7 +18,7 @@ sourceDistIncubating := false
ThisBuild / reproducibleBuildsCheckResolver := Resolver.ApacheMavenStagingRepo
ThisBuild / javafmtFormatterCompatibleJavaVersion := 17
-addCommandAlias("verifyCodeStyle", "scalafmtCheckAll; scalafmtSbtCheck;
+headerCheckAll; javafmtCheckAll")
+addCommandAlias("checkCodeStyle", "scalafmtCheckAll; scalafmtSbtCheck;
javafmtCheckAll; +headerCheckAll")
addCommandAlias("applyCodeStyle", "+headerCreateAll; scalafmtAll; scalafmtSbt;
javafmtAll")
addCommandAlias("verifyDocs", ";+doc ;unidoc ;docs/paradoxBrowse")
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
