This is an automated email from the ASF dual-hosted git repository.
He-Pin pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pekko-connectors.git
The following commit(s) were added to refs/heads/main by this push:
new bd6015ec8 refactor: modernize Java test code with Java 17 records
(#1697)
bd6015ec8 is described below
commit bd6015ec85cbdd64ca60716bf2da5136413e4cbd
Author: He-Pin(kerr) <[email protected]>
AuthorDate: Fri Jun 19 17:26:55 2026 +0800
refactor: modernize Java test code with Java 17 records (#1697)
* fix: correct various typos across pekko-connectors modules
Motivation:
Several typos were found in comments, strings, docs, and config files.
Modification:
- Fix typos in docs, configs, test files, and source code
- Includes: Compatibilty→Compatibility, mutliple→multiple,
retrived→retrieved,
containg→containing, incase→in case, everytime→every time, Ontop→On top,
alterante→alternate, inital→initial, extisting→existing,
conector→connector,
propogate→propagate, soruce→source, Kakfa→Kafka, followings→following,
realy→really, hypens→hyphens, withing→within, occassions→occasions,
compatibile→compatible, defauls→defaults, cant→can't
Result:
Cleaner codebase with corrected spelling.
Tests:
Not run - typo fixes only (comments, strings, docs, config values)
References:
None - typo cleanup
* style: apply javafmt formatting
Motivation:
CI requires javafmt formatting for all Java files.
Modification:
Run sbt javafmtAll to apply standard Java formatting
to JavaDslTest.java.
Result:
All Java files pass javafmt checks.
Tests:
Not run - formatting only
References:
None - formatting fix
* refactor: modernize Java test code with Java 17 records
Motivation:
Java 17 introduced records that make Java code more concise by
eliminating boilerplate for data carrier classes.
Modification:
- Convert User class to a record in slick module tests
- Convert Person class to a record in cassandra module tests
- Update all field accesses to use record accessor methods
Result:
Test Java code is more concise and idiomatic for Java 17+, removing
redundant equals/hashCode boilerplate.
Tests:
sbt javafmtAll (passes)
sbt "slick / Test / compile"
sbt "cassandra / Test / compile"
References:
None - code modernization
---
.../test/java/docs/javadsl/CassandraFlowTest.java | 28 +----------------
.../src/test/java/docs/javadsl/DocSnippetFlow.java | 4 +--
.../javadsl/DocSnippetFlowWithPassThrough.java | 4 +--
.../src/test/java/docs/javadsl/DocSnippetSink.java | 4 +--
slick/src/test/java/docs/javadsl/SlickTest.java | 8 ++---
slick/src/test/java/docs/javadsl/User.java | 36 +---------------------
6 files changed, 12 insertions(+), 72 deletions(-)
diff --git a/cassandra/src/test/java/docs/javadsl/CassandraFlowTest.java
b/cassandra/src/test/java/docs/javadsl/CassandraFlowTest.java
index 4be99698e..2a5ce0c85 100644
--- a/cassandra/src/test/java/docs/javadsl/CassandraFlowTest.java
+++ b/cassandra/src/test/java/docs/javadsl/CassandraFlowTest.java
@@ -39,7 +39,6 @@ import org.junit.Test;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
-import java.util.Objects;
import java.util.concurrent.*;
import static org.hamcrest.CoreMatchers.*;
@@ -191,32 +190,7 @@ public class CassandraFlowTest {
assertThat(new ArrayList<>(rows), hasItems(persons.stream().map(p ->
p.first()).toArray()));
}
- public static final class Person {
- public final int id;
- public final String name;
- public final String city;
-
- public Person(int id, String name, String city) {
- this.id = id;
- this.name = name;
- this.city = city;
- }
-
- @Override
- public boolean equals(Object o) {
- if (this == o) return true;
- if (o == null || getClass() != o.getClass()) return false;
- Person that = (Person) o;
- return Objects.equals(id, that.id)
- && Objects.equals(name, that.name)
- && Objects.equals(city, that.city);
- }
-
- @Override
- public int hashCode() {
- return Objects.hash(id, name, city);
- }
- }
+ public record Person(int id, String name, String city) {}
public static final class AckHandle {
public CompletionStage<Done> ack() {
diff --git a/slick/src/test/java/docs/javadsl/DocSnippetFlow.java
b/slick/src/test/java/docs/javadsl/DocSnippetFlow.java
index 00dcb77ff..53504134b 100644
--- a/slick/src/test/java/docs/javadsl/DocSnippetFlow.java
+++ b/slick/src/test/java/docs/javadsl/DocSnippetFlow.java
@@ -53,8 +53,8 @@ public class DocSnippetFlow {
connection.prepareStatement(
"INSERT INTO
PEKKO_CONNECTORS_SLICK_JAVADSL_TEST_USERS VALUES (?,"
+ " ?)");
- statement.setInt(1, user.id);
- statement.setString(2, user.name);
+ statement.setInt(1, user.id());
+ statement.setString(2, user.name());
return statement;
}))
.log("nr-of-updated-rows")
diff --git
a/slick/src/test/java/docs/javadsl/DocSnippetFlowWithPassThrough.java
b/slick/src/test/java/docs/javadsl/DocSnippetFlowWithPassThrough.java
index 2b68b2b26..a7195c6c0 100644
--- a/slick/src/test/java/docs/javadsl/DocSnippetFlowWithPassThrough.java
+++ b/slick/src/test/java/docs/javadsl/DocSnippetFlowWithPassThrough.java
@@ -91,8 +91,8 @@ public class DocSnippetFlowWithPassThrough {
connection.prepareStatement(
"INSERT INTO
PEKKO_CONNECTORS_SLICK_JAVADSL_TEST_USERS VALUES (?,"
+ " ?)");
- statement.setInt(1, kafkaMessage.msg.id);
- statement.setString(2, kafkaMessage.msg.name);
+ statement.setInt(1, kafkaMessage.msg.id());
+ statement.setString(2, kafkaMessage.msg.name());
return statement;
},
(kafkaMessage, insertCount) ->
diff --git a/slick/src/test/java/docs/javadsl/DocSnippetSink.java
b/slick/src/test/java/docs/javadsl/DocSnippetSink.java
index 2f02506c5..c76022f05 100644
--- a/slick/src/test/java/docs/javadsl/DocSnippetSink.java
+++ b/slick/src/test/java/docs/javadsl/DocSnippetSink.java
@@ -50,8 +50,8 @@ public class DocSnippetSink {
connection.prepareStatement(
"INSERT INTO
PEKKO_CONNECTORS_SLICK_JAVADSL_TEST_USERS VALUES (?,"
+ " ?)");
- statement.setInt(1, user.id);
- statement.setString(2, user.name);
+ statement.setInt(1, user.id());
+ statement.setString(2, user.name());
return statement;
}),
system);
diff --git a/slick/src/test/java/docs/javadsl/SlickTest.java
b/slick/src/test/java/docs/javadsl/SlickTest.java
index 91ad1574c..9acc1c081 100644
--- a/slick/src/test/java/docs/javadsl/SlickTest.java
+++ b/slick/src/test/java/docs/javadsl/SlickTest.java
@@ -72,9 +72,9 @@ public class SlickTest {
private static final Function<User, String> insertUser =
(user) ->
"INSERT INTO PEKKO_CONNECTORS_SLICK_JAVADSL_TEST_USERS VALUES ("
- + user.id
+ + user.id()
+ ", '"
- + user.name
+ + user.name()
+ "')";
private static final Function2<User, Connection, PreparedStatement>
insertUserPS =
@@ -82,8 +82,8 @@ public class SlickTest {
PreparedStatement statement =
connection.prepareStatement(
"INSERT INTO PEKKO_CONNECTORS_SLICK_JAVADSL_TEST_USERS VALUES
(?, ?)");
- statement.setInt(1, user.id);
- statement.setString(2, user.name);
+ statement.setInt(1, user.id());
+ statement.setString(2, user.name());
return statement;
};
diff --git a/slick/src/test/java/docs/javadsl/User.java
b/slick/src/test/java/docs/javadsl/User.java
index 40db1c89a..b90acf4fa 100644
--- a/slick/src/test/java/docs/javadsl/User.java
+++ b/slick/src/test/java/docs/javadsl/User.java
@@ -13,38 +13,4 @@
package docs.javadsl;
-public class User {
- public final Integer id;
- public final String name;
-
- public User(Integer _id, String _name) {
- id = _id;
- name = _name;
- }
-
- @Override
- public int hashCode() {
- int hash = 3;
- hash = 53 * hash + (this.name != null ? this.name.hashCode() : 0);
- hash = 53 * hash + this.id;
- return hash;
- }
-
- @Override
- public boolean equals(Object obj) {
- if (obj == null) {
- return false;
- }
- if (!User.class.isAssignableFrom(obj.getClass())) {
- return false;
- }
- final User other = (User) obj;
- if ((this.name == null) ? (other.name != null) :
!this.name.equals(other.name)) {
- return false;
- }
- if (this.id != other.id) {
- return false;
- }
- return true;
- }
-}
+public record User(Integer id, String name) {}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
