This is an automated email from the ASF dual-hosted git repository.
He-Pin pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pekko-connectors.git
The following commit(s) were added to refs/heads/main by this push:
new c66562797 refactor: use Files.writeString (Java 11+) (#1722)
c66562797 is described below
commit c665627978f268d9b3de5eaf6c9acf6410a143ea
Author: He-Pin(kerr) <[email protected]>
AuthorDate: Fri Jun 26 16:21:32 2026 +0800
refactor: use Files.writeString (Java 11+) (#1722)
Motivation:
Files.writeString was introduced in Java 11 and provides a cleaner API
for writing a String to a file, replacing the
Files.write(path, str.getBytes(charset)) pattern.
Modification:
Replace Files.write(path, str.getBytes(charset)) with
Files.writeString(path, str, charset) in file module tests.
Result:
More idiomatic Java 11+ code with identical behavior.
Tests:
Not run - behavior-preserving refactoring
References:
None - Java 11+ API migration
---
.../test/java/docs/javadsl/DirectoryChangesSourceTest.java | 2 +-
file/src/test/java/docs/javadsl/FileTailSourceTest.java | 12 ++++++------
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/file/src/test/java/docs/javadsl/DirectoryChangesSourceTest.java
b/file/src/test/java/docs/javadsl/DirectoryChangesSourceTest.java
index 6b9615483..1202471a3 100644
--- a/file/src/test/java/docs/javadsl/DirectoryChangesSourceTest.java
+++ b/file/src/test/java/docs/javadsl/DirectoryChangesSourceTest.java
@@ -91,7 +91,7 @@ public class DirectoryChangesSourceTest {
assertEquals(pair1.second(), DirectoryChange.Creation);
assertEquals(pair1.first(), createdFile);
- Files.write(createdFile, "Some data".getBytes());
+ Files.writeString(createdFile, "Some data");
final Pair<Path, DirectoryChange> pair2 = probe.requestNext();
assertEquals(pair2.second(), DirectoryChange.Modification);
diff --git a/file/src/test/java/docs/javadsl/FileTailSourceTest.java
b/file/src/test/java/docs/javadsl/FileTailSourceTest.java
index 02a797c9d..856f70973 100644
--- a/file/src/test/java/docs/javadsl/FileTailSourceTest.java
+++ b/file/src/test/java/docs/javadsl/FileTailSourceTest.java
@@ -74,7 +74,7 @@ public class FileTailSourceTest {
public void canReadAnEntireFile() throws Exception {
final Path path = fs.getPath("/file");
final String dataInFile = "a\nb\nc\nd";
- Files.write(path, dataInFile.getBytes(UTF_8));
+ Files.writeString(path, dataInFile, UTF_8);
final Source<ByteString, NotUsed> source =
org.apache.pekko.stream.connectors.file.javadsl.FileTailSource.create(
@@ -101,7 +101,7 @@ public class FileTailSourceTest {
@Test
public void willReadNewLinesAppendedAfterReadingTheInitialContents() throws
Exception {
final Path path = fs.getPath("/file");
- Files.write(path, "a\n".getBytes(UTF_8));
+ Files.writeString(path, "a\n", UTF_8);
final Source<String, NotUsed> source =
org.apache.pekko.stream.connectors.file.javadsl.FileTailSource.createLines(
@@ -123,10 +123,10 @@ public class FileTailSourceTest {
assertEquals("a", result1);
subscriber.request(1);
- Files.write(path, "b\n".getBytes(UTF_8), WRITE, APPEND);
+ Files.writeString(path, "b\n", UTF_8, WRITE, APPEND);
assertEquals("b", subscriber.expectNext());
- Files.write(path, "c\n".getBytes(UTF_8), WRITE, APPEND);
+ Files.writeString(path, "c\n", UTF_8, WRITE, APPEND);
subscriber.request(1);
assertEquals("c", subscriber.expectNext());
@@ -137,7 +137,7 @@ public class FileTailSourceTest {
@Test
public void willCompleteStreamIfFileIsDeleted() throws Exception {
final Path path = fs.getPath("/file");
- Files.write(path, "a\n".getBytes(UTF_8));
+ Files.writeString(path, "a\n", UTF_8);
final TestSubscriber.Probe<String> subscriber =
TestSubscriber.probe(system);
@@ -183,7 +183,7 @@ public class FileTailSourceTest {
@Test
public void willCompleteStreamIfFileIsIdle() throws Exception {
final Path path = fs.getPath("/file");
- Files.write(path, "a\n".getBytes(UTF_8));
+ Files.writeString(path, "a\n", UTF_8);
final TestSubscriber.Probe<String> subscriber =
TestSubscriber.probe(system);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
