This is an automated email from the ASF dual-hosted git repository.
He-Pin pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pekko-grpc.git
The following commit(s) were added to refs/heads/main by this push:
new 162dfe98 refactor: replace .collect(Collectors.toList()) with
.toList() (#752)
162dfe98 is described below
commit 162dfe989e180b2036c13b871b7b1e5267abf0c5
Author: He-Pin(kerr) <[email protected]>
AuthorDate: Fri Jun 26 21:53:31 2026 +0800
refactor: replace .collect(Collectors.toList()) with .toList() (#752)
* refactor: replace .collect(Collectors.toList()) with .toList()
Motivation:
Java 16+ Stream.toList() provides a concise way to collect stream
elements into an unmodifiable list.
Modification:
Replace .collect(Collectors.toList()) with .toList() across 4 files.
Remove unused Collectors imports.
Result:
Cleaner stream collection code using Java 17 API.
Tests:
Not run - compile-only test file changes
References:
None - Java 17 API modernization
* fix: apply javafmt formatting
---
.../src/main/java/example/myapp/helloworld/GreeterClient.java | 3 +--
.../main/java/example/myapp/helloworld/GreeterServiceImpl.java | 9 ++-------
.../main/java/example/myapp/helloworld/LiftedGreeterClient.java | 3 +--
.../java/example/myapp/helloworld/PowerGreeterServiceImpl.java | 9 ++-------
4 files changed, 6 insertions(+), 18 deletions(-)
diff --git
a/plugin-tester-java/src/main/java/example/myapp/helloworld/GreeterClient.java
b/plugin-tester-java/src/main/java/example/myapp/helloworld/GreeterClient.java
index e19f2394..d5d2d393 100644
---
a/plugin-tester-java/src/main/java/example/myapp/helloworld/GreeterClient.java
+++
b/plugin-tester-java/src/main/java/example/myapp/helloworld/GreeterClient.java
@@ -20,7 +20,6 @@ import java.time.Duration;
import java.util.List;
import java.util.concurrent.CompletionStage;
import java.util.concurrent.TimeUnit;
-import java.util.stream.Collectors;
import java.util.stream.Stream;
import org.apache.pekko.Done;
import org.apache.pekko.NotUsed;
@@ -72,7 +71,7 @@ class GreeterClient {
List<HelloRequest> requests =
Stream.of("Alice", "Bob", "Peter")
.map(name -> HelloRequest.newBuilder().setName(name).build())
- .collect(Collectors.toList());
+ .toList();
CompletionStage<HelloReply> reply =
client.itKeepsTalking(Source.from(requests));
System.out.println(
"got single reply for streaming requests: "
diff --git
a/plugin-tester-java/src/main/java/example/myapp/helloworld/GreeterServiceImpl.java
b/plugin-tester-java/src/main/java/example/myapp/helloworld/GreeterServiceImpl.java
index adb6370b..f9d880c2 100644
---
a/plugin-tester-java/src/main/java/example/myapp/helloworld/GreeterServiceImpl.java
+++
b/plugin-tester-java/src/main/java/example/myapp/helloworld/GreeterServiceImpl.java
@@ -19,7 +19,6 @@ import example.myapp.helloworld.grpc.*;
import java.util.List;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.CompletionStage;
-import java.util.stream.Collectors;
import org.apache.pekko.NotUsed;
import org.apache.pekko.stream.Materializer;
import org.apache.pekko.stream.javadsl.Sink;
@@ -49,11 +48,7 @@ public class GreeterServiceImpl implements GreeterService {
return in.runWith(Sink.<HelloRequest>seq(), mat)
.thenApply(
elements -> {
- String elementsStr =
- elements.stream()
- .map(HelloRequest::getName)
- .collect(Collectors.toList())
- .toString();
+ String elementsStr =
elements.stream().map(HelloRequest::getName).toList().toString();
return HelloReply.newBuilder().setMessage("Hello, " +
elementsStr).build();
});
}
@@ -62,7 +57,7 @@ public class GreeterServiceImpl implements GreeterService {
public Source<HelloReply, NotUsed> itKeepsReplying(HelloRequest in) {
System.out.println("sayHello to " + in.getName() + " with stream of
chars");
List<Character> characters =
- ("Hello, " + in.getName()).chars().mapToObj(c -> (char)
c).collect(Collectors.toList());
+ ("Hello, " + in.getName()).chars().mapToObj(c -> (char) c).toList();
return Source.from(characters)
.map(character ->
HelloReply.newBuilder().setMessage(String.valueOf(character)).build());
}
diff --git
a/plugin-tester-java/src/main/java/example/myapp/helloworld/LiftedGreeterClient.java
b/plugin-tester-java/src/main/java/example/myapp/helloworld/LiftedGreeterClient.java
index d3d56c8f..72b8e840 100644
---
a/plugin-tester-java/src/main/java/example/myapp/helloworld/LiftedGreeterClient.java
+++
b/plugin-tester-java/src/main/java/example/myapp/helloworld/LiftedGreeterClient.java
@@ -19,7 +19,6 @@ import java.time.Duration;
import java.util.List;
import java.util.concurrent.CompletionStage;
import java.util.concurrent.TimeUnit;
-import java.util.stream.Collectors;
import java.util.stream.Stream;
import org.apache.pekko.Done;
import org.apache.pekko.NotUsed;
@@ -68,7 +67,7 @@ class LiftedGreeterClient {
List<HelloRequest> requests =
Stream.of("Alice", "Bob", "Peter")
.map(name -> HelloRequest.newBuilder().setName(name).build())
- .collect(Collectors.toList());
+ .toList();
CompletionStage<HelloReply> reply =
client.itKeepsTalking().addHeader("key",
"value").invoke(Source.from(requests));
System.out.println(
diff --git
a/plugin-tester-java/src/main/java/example/myapp/helloworld/PowerGreeterServiceImpl.java
b/plugin-tester-java/src/main/java/example/myapp/helloworld/PowerGreeterServiceImpl.java
index 603d3334..cfff3d3b 100644
---
a/plugin-tester-java/src/main/java/example/myapp/helloworld/PowerGreeterServiceImpl.java
+++
b/plugin-tester-java/src/main/java/example/myapp/helloworld/PowerGreeterServiceImpl.java
@@ -20,7 +20,6 @@ import example.myapp.helloworld.grpc.HelloRequest;
import java.util.List;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.CompletionStage;
-import java.util.stream.Collectors;
import org.apache.pekko.NotUsed;
import org.apache.pekko.grpc.javadsl.Metadata;
import org.apache.pekko.stream.Materializer;
@@ -50,10 +49,7 @@ public class PowerGreeterServiceImpl implements
GreeterServicePowerApi {
.thenApply(
elements -> {
String elementsStr =
- elements.stream()
- .map(elem -> authTaggedName(elem, metadata))
- .collect(Collectors.toList())
- .toString();
+ elements.stream().map(elem -> authTaggedName(elem,
metadata)).toList().toString();
return HelloReply.newBuilder().setMessage("Hello, " +
elementsStr).build();
});
}
@@ -62,8 +58,7 @@ public class PowerGreeterServiceImpl implements
GreeterServicePowerApi {
public Source<HelloReply, NotUsed> itKeepsReplying(HelloRequest in, Metadata
metadata) {
String greetee = authTaggedName(in, metadata);
System.out.println("sayHello to " + greetee + " with stream of chars");
- List<Character> characters =
- ("Hello, " + greetee).chars().mapToObj(c -> (char)
c).collect(Collectors.toList());
+ List<Character> characters = ("Hello, " + greetee).chars().mapToObj(c ->
(char) c).toList();
return Source.from(characters)
.map(character ->
HelloReply.newBuilder().setMessage(String.valueOf(character)).build());
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
