This is an automated email from the ASF dual-hosted git repository.
pjfanning pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pekko-http.git
The following commit(s) were added to refs/heads/main by this push:
new fe2e67ee9 fix: avoid unmoored doc comments (#1115)
fe2e67ee9 is described below
commit fe2e67ee96346c3cb24d8c0c7e2e253666649101
Author: Matthias Kurz <[email protected]>
AuthorDate: Wed Jul 1 12:02:03 2026 +0200
fix: avoid unmoored doc comments (#1115)
The publish workflow now treats Scala compiler warnings as errors.
Scala 3 reports local Scaladoc comments as discarded unmoored
doc comments, which breaks the cross-built publish task.
---
.../pekko/http/impl/engine/client/pool/NewHostConnectionPool.scala | 2 +-
.../org/apache/pekko/http/impl/engine/http2/StreamPrioritizer.scala | 6 ++----
.../pekko/http/impl/engine/rendering/DateHeaderRendering.scala | 2 +-
3 files changed, 4 insertions(+), 6 deletions(-)
diff --git
a/http-core/src/main/scala/org/apache/pekko/http/impl/engine/client/pool/NewHostConnectionPool.scala
b/http-core/src/main/scala/org/apache/pekko/http/impl/engine/client/pool/NewHostConnectionPool.scala
index a62ece91e..fc1948bf1 100644
---
a/http-core/src/main/scala/org/apache/pekko/http/impl/engine/client/pool/NewHostConnectionPool.scala
+++
b/http-core/src/main/scala/org/apache/pekko/http/impl/engine/client/pool/NewHostConnectionPool.scala
@@ -375,7 +375,7 @@ private[client] object NewHostConnectionPool {
OptionVal.Some(Event.onPreConnect)
}
- /** Run a loop of state transitions */
+ // Run a loop of state transitions
/* @tailrec (does not work for some reason?) */
def loop[U](event: Event[U], arg: U, remainingIterations: Int):
Unit =
if (remainingIterations > 0)
diff --git
a/http-core/src/main/scala/org/apache/pekko/http/impl/engine/http2/StreamPrioritizer.scala
b/http-core/src/main/scala/org/apache/pekko/http/impl/engine/http2/StreamPrioritizer.scala
index 33c6bc08b..afdd36e0f 100644
---
a/http-core/src/main/scala/org/apache/pekko/http/impl/engine/http2/StreamPrioritizer.scala
+++
b/http-core/src/main/scala/org/apache/pekko/http/impl/engine/http2/StreamPrioritizer.scala
@@ -57,10 +57,8 @@ private[http2] object StreamPrioritizer {
/** Choose a substream from a set of substream ids that have data
available */
def chooseSubstream(streams: Set[Int]): Int = {
- /**
- * Chooses one of the children, returns the chosen stream id (which
must be part of `streams` or
- * -1 if no eligible stream was found in that part of the tree).
- */
+ // Chooses one of the children, returns the chosen stream id (which
must be part of `streams` or
+ // -1 if no eligible stream was found in that part of the tree).
def chooseFromChildren(prioNode: PriorityNode): Int = {
if (streams.contains(prioNode.streamId)) prioNode.streamId
else {
diff --git
a/http-core/src/main/scala/org/apache/pekko/http/impl/engine/rendering/DateHeaderRendering.scala
b/http-core/src/main/scala/org/apache/pekko/http/impl/engine/rendering/DateHeaderRendering.scala
index 7adfa7f44..ff1f8ffad 100644
---
a/http-core/src/main/scala/org/apache/pekko/http/impl/engine/rendering/DateHeaderRendering.scala
+++
b/http-core/src/main/scala/org/apache/pekko/http/impl/engine/rendering/DateHeaderRendering.scala
@@ -43,7 +43,7 @@ import scala.concurrent.ExecutionContext
sealed trait DateState
- /** Date has not been used for a while */
+ // Date has not been used for a while
case object Idle extends DateState
case class AutoUpdated(value: String) extends DateState {
var wasUsed: Boolean = false
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
