This is an automated email from the ASF dual-hosted git repository.
He-Pin pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pekko-grpc.git
The following commit(s) were added to refs/heads/main by this push:
new ac696fad test: remove Gradle 4.0 from compatibility test (#777)
ac696fad is described below
commit ac696fada1b57ce3625831c18b91df48c93e558a
Author: He-Pin(kerr) <[email protected]>
AuthorDate: Sun Jul 5 01:31:31 2026 +0800
test: remove Gradle 4.0 from compatibility test (#777)
Motivation:
The GradleCompatibilitySpecTest downloads Gradle 4.0 distribution from
services.gradle.org during CI, which frequently times out causing
spurious test failures unrelated to code changes.
Modification:
Remove Gradle 4.0 from the failVersions parameterized test. Gradle 5.5
remains to verify the "below minimum 5.6" rejection logic. Simplify the
assumeGradleVersionCanRunOnCurrentJava guard that had a special case for
4.0.
Result:
More reliable CI with no loss of test coverage for the minimum version
check.
---
gradle-plugin/src/test/java/func/GradleCompatibilitySpecTest.java | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/gradle-plugin/src/test/java/func/GradleCompatibilitySpecTest.java
b/gradle-plugin/src/test/java/func/GradleCompatibilitySpecTest.java
index b7c79663..fda4d51c 100644
--- a/gradle-plugin/src/test/java/func/GradleCompatibilitySpecTest.java
+++ b/gradle-plugin/src/test/java/func/GradleCompatibilitySpecTest.java
@@ -65,8 +65,7 @@ class GradleCompatibilitySpecTest extends BaseSpec {
static Stream<Arguments> failVersions() {
return Stream.of(
- Arguments.of("5.5"),
- Arguments.of("4.0"));
+ Arguments.of("5.5"));
}
@ParameterizedTest(name = "should fail for version {0} less than 5.6")
@@ -86,8 +85,7 @@ class GradleCompatibilitySpecTest extends BaseSpec {
private static void assumeGradleVersionCanRunOnCurrentJava(String
gradleVersion) {
Assumptions.assumeFalse(
Runtime.version().feature() >= 17 &&
-
GradleVersion.version(gradleVersion).compareTo(GradleVersion.version("7.3")) <
0 &&
-
!GradleVersion.version(gradleVersion).equals(GradleVersion.version("4.0")),
+
GradleVersion.version(gradleVersion).compareTo(GradleVersion.version("7.3")) <
0,
"Gradle " + gradleVersion + " cannot run on Java " +
Runtime.version().feature());
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
