This is an automated email from the ASF dual-hosted git repository.
pjfanning pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pekko-management.git
The following commit(s) were added to refs/heads/main by this push:
new 237719ff Update scala-library to 3.9.0 (#962)
237719ff is described below
commit 237719ff2100016da8698a33805261b13abb80da
Author: Scala Steward <[email protected]>
AuthorDate: Fri Sep 4 21:54:00 2026 +0200
Update scala-library to 3.9.0 (#962)
* Update scala-library to 3.9.0
* fix
* Skip MiMa checks when building with Scala 3.9.0
Motivation:
This PR adds Scala 3.9.0 to crossScalaVersions. Scala 3.9.0 shares the "_3"
binary suffix with the existing 3.3 artifacts, so `+mimaReportBinaryIssues`
picks up the released 3.3-built artifacts and checks them against classes
compiled by a much newer compiler. There is no released artifact built with
3.9.0 to compare against, so that check carries no useful signal.
Modification:
Make the shared `mimaPreviousArtifactsSet` setting resolve to `Set.empty`
when `scalaVersion` is `Dependencies.scala3NextVersion`, which covers every
module that uses it.
Result:
`sbt +mimaReportBinaryIssues` still checks Scala 2.13 and Scala 3.3, and
reports "mimaPreviousArtifacts is empty, not analyzing binary compatibility"
for Scala 3.9.0.
Tests:
- `sbt -batch "show discovery-kubernetes-api/mimaPreviousArtifacts"
"++3.3.8 discovery-kubernetes-api/mimaPreviousArtifacts" "++3.9.0
discovery-kubernetes-api/mimaPreviousArtifacts"` - 2.13 and 3.3.8 keep
pekko-discovery-kubernetes-api:1.0.0, 3.9.0 is empty
- `sbt -batch scalafmtSbtCheck "++3.9.0
discovery-kubernetes-api/mimaReportBinaryIssues"` - success, the analysis is
skipped
References:
Refs #962
* Update unit-tests.yml
---------
Co-authored-by: PJ Fanning <[email protected]>
---
.github/workflows/unit-tests.yml | 2 +-
build.sbt | 9 +++++++--
project/Dependencies.scala | 2 +-
3 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
index 48cc2652..981ba007 100644
--- a/.github/workflows/unit-tests.yml
+++ b/.github/workflows/unit-tests.yml
@@ -20,7 +20,7 @@ jobs:
include:
- { javaVersion: 17, scalaVersion: 2.13, sbtOpts: '' }
- { javaVersion: 17, scalaVersion: 3.3, sbtOpts: '' }
- - { javaVersion: 17, scalaVersion: 3.8, sbtOpts: '' }
+ - { javaVersion: 17, scalaVersion: 3.9, sbtOpts: '' }
steps:
- name: Checkout
uses: actions/checkout@v7
diff --git a/build.sbt b/build.sbt
index 5fab0d09..997daa9e 100644
--- a/build.sbt
+++ b/build.sbt
@@ -75,8 +75,13 @@ lazy val root = project
.enablePlugins(NoPublish)
val mimaCompareVersion = "1.0.0"
-lazy val mimaPreviousArtifactsSet = mimaPreviousArtifacts := Set(
- organization.value %% name.value % mimaCompareVersion)
+lazy val mimaPreviousArtifactsSet = mimaPreviousArtifacts := {
+ // no MiMa check for the next Scala 3 version, there are no released
artifacts built with it
+ if (scalaVersion.value == Dependencies.scala3NextVersion)
+ Set.empty
+ else
+ Set(organization.value %% name.value % mimaCompareVersion)
+}
lazy val discoveryKubernetesApi = pekkoModule("discovery-kubernetes-api")
.enablePlugins(AutomateHeaderPlugin, ReproducibleBuildsPlugin)
diff --git a/project/Dependencies.scala b/project/Dependencies.scala
index 943db9f9..4873dff3 100644
--- a/project/Dependencies.scala
+++ b/project/Dependencies.scala
@@ -13,7 +13,7 @@ object Dependencies {
// keep in sync with .github/workflows/unit-tests.yml
val scala213Version = "2.13.18"
val scala3Version = "3.3.8"
- val scala3NextVersion = "3.8.4"
+ val scala3NextVersion = "3.9.0"
val crossScalaVersions = Seq(scala213Version, scala3Version,
scala3NextVersion)
val pekkoVersion = PekkoCoreDependency.version
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
