This is an automated email from the ASF dual-hosted git repository.
pjfanning pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pekko-management.git
The following commit(s) were added to refs/heads/main by this push:
new c4e65e04 Update sbt-mima-plugin to 1.2.0 (#967)
c4e65e04 is described below
commit c4e65e04f30bc59996745b1dd64f6da8aa7b141d
Author: Scala Steward <[email protected]>
AuthorDate: Tue Sep 8 22:39:07 2026 +0200
Update sbt-mima-plugin to 1.2.0 (#967)
* Update sbt-mima-plugin to 1.2.0
* Add MiMa excludes for the internal LeaseActor
Motivation:
MiMa 1.2.0 reports four problems in pekko-lease-kubernetes against the
1.0.0 baseline that MiMa 1.1.6 did not: LeaseActor.props and the
LeaseActor constructor lost their four-argument forms when
heartbeatMaxRetries and releaseMaxRetries were added in #911, and the
forwarder for the deprecated FSM.setTimer that LeaseActor inherited from
LoggingFSM (with its setTimer$default$4) is no longer emitted. LeaseActor
is private[pekko] internal API, so none of these are part of the public
surface, but the check fails the build.
Modification:
Add lease-actor-internal.backwards.excludes under
lease-kubernetes/src/main/mima-filters/2.0.x.backwards.excludes with the
four DirectMissingMethodProblem filters MiMa suggests, and a comment
recording why each one is safe.
Result:
mimaReportBinaryIssues passes on all cross-built Scala versions with
sbt-mima-plugin 1.2.0.
Tests:
- sbt "+mimaReportBinaryIssues" - success on 2.13.18, 3.3.8 and 3.9.0
- sbt headerCheckAll - success
- No Scala sources changed, so no directional test is added
References:
Refs #967, Refs #911
---------
Co-authored-by: PJ Fanning <[email protected]>
---
.../lease-actor-internal.backwards.excludes | 25 ++++++++++++++++++++++
project/plugins.sbt | 2 +-
2 files changed, 26 insertions(+), 1 deletion(-)
diff --git
a/lease-kubernetes/src/main/mima-filters/2.0.x.backwards.excludes/lease-actor-internal.backwards.excludes
b/lease-kubernetes/src/main/mima-filters/2.0.x.backwards.excludes/lease-actor-internal.backwards.excludes
new file mode 100644
index 00000000..7a3efa9d
--- /dev/null
+++
b/lease-kubernetes/src/main/mima-filters/2.0.x.backwards.excludes/lease-actor-internal.backwards.excludes
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# LeaseActor is private[pekko] internal API. MiMa 1.2.0 reports these changes
that
+# MiMa 1.1.6 did not: props and the constructor gained heartbeatMaxRetries and
+# releaseMaxRetries (#911), and the forwarder for the deprecated FSM.setTimer
that
+# LeaseActor inherited from LoggingFSM is no longer emitted.
+ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.coordination.lease.kubernetes.LeaseActor.props")
+ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.coordination.lease.kubernetes.LeaseActor.setTimer")
+ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.coordination.lease.kubernetes.LeaseActor.setTimer$default$4")
+ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.coordination.lease.kubernetes.LeaseActor.this")
diff --git a/project/plugins.sbt b/project/plugins.sbt
index b91d91f1..e4e3beef 100644
--- a/project/plugins.sbt
+++ b/project/plugins.sbt
@@ -20,7 +20,7 @@ addSbtPlugin("com.github.pjfanning" % "sbt-source-dist" %
"0.2.0")
addSbtPlugin("com.github.pjfanning" % "sbt-pekko-build" % "0.4.7")
addSbtPlugin("com.github.sbt" % "sbt-license-report" % "1.10.0")
addSbtPlugin("com.github.sbt" % "sbt-git" % "2.1.0")
-addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.1.6")
+addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.2.0")
addSbtPlugin("com.lightbend.sbt" % "sbt-bill-of-materials" % "1.1.1")
addSbtPlugin("com.github.sbt.junit" % "sbt-jupiter-interface" % "0.19.0")
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
