This is an automated email from the ASF dual-hosted git repository.
pjfanning pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pekko-connectors.git
The following commit(s) were added to refs/heads/main by this push:
new b6d96ae5d Update sbt-mima-plugin to 1.2.0 (#1931)
b6d96ae5d is described below
commit b6d96ae5d31971b314e380c7eb6f14c43cc9af6a
Author: Scala Steward <[email protected]>
AuthorDate: Tue Sep 8 23:20:02 2026 +0200
Update sbt-mima-plugin to 1.2.0 (#1931)
* Update sbt-mima-plugin to 1.2.0
* Google: MiMa excludes for singleRequest under sbt-mima-plugin 1.2.0
Motivation:
The sbt-mima-plugin 1.2.0 bump fails the Binary Compatibility job. MiMa
1.2.0
reports the singleRequest implicit-parameter reordering from #1682 more
completely than 1.1.6 did: google-common gets two previously unreported
problems
on scaladsl.Google (the trait's method is seen as missing and the companion
object's signature as changed), and google-cloud-bigquery gets a
DirectMissingMethodProblem alongside the IncompatibleMethTypeProblem already
excluded there.
Modification:
Add
google-common/src/main/mima-filters/2.0.x.backwards.excludes/context-bounds.excludes
covering DirectMissingMethodProblem and IncompatibleMethTypeProblem on
scaladsl.Google.singleRequest, and add the matching
DirectMissingMethodProblem
for BigQuery.singleRequest to the existing google-cloud-bigquery exclude
file.
Result:
Both MiMa passes the job runs are clean under 1.2.0. The filters are inert
under
1.1.6, so they describe only the reordering itself, not the plugin version.
Tests:
- sbt "google-common/mimaReportBinaryIssues"
"google-cloud-bigquery/mimaReportBinaryIssues" - success
- sbt "++3.3.8! mimaReportBinaryIssues" (all modules) - success, 13m29s.
The job
never reached the Scala 3 pass, since sbt aborts the chained command
sequence
once the 2.13 pass fails, so it was run locally.
- Negative check with the new google-common file removed reproduced the CI
failure exactly: "Found 2 potential problems (filtered 2)"
References:
Refs #1682
---------
Co-authored-by: PJ Fanning <[email protected]>
---
.../mima-filters/2.0.x.backward.excludes/context-bounds.excludes | 2 ++
.../mima-filters/2.0.x.backwards.excludes}/context-bounds.excludes | 6 ++++--
project/plugins.sbt | 2 +-
3 files changed, 7 insertions(+), 3 deletions(-)
diff --git
a/google-cloud-bigquery/src/main/mima-filters/2.0.x.backward.excludes/context-bounds.excludes
b/google-cloud-bigquery/src/main/mima-filters/2.0.x.backward.excludes/context-bounds.excludes
index a8b18fe12..910c0bcc1 100644
---
a/google-cloud-bigquery/src/main/mima-filters/2.0.x.backward.excludes/context-bounds.excludes
+++
b/google-cloud-bigquery/src/main/mima-filters/2.0.x.backward.excludes/context-bounds.excludes
@@ -20,3 +20,5 @@
# This is a binary-incompatible change but does not affect source-level callers
# using implicit resolution. BigQuery API is @ApiMayChange.
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.pekko.stream.connectors.googlecloud.bigquery.scaladsl.BigQuery.singleRequest")
+# MiMa 1.2.0 additionally reports the old signature as missing outright.
+ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.stream.connectors.googlecloud.bigquery.scaladsl.BigQuery.singleRequest")
diff --git
a/google-cloud-bigquery/src/main/mima-filters/2.0.x.backward.excludes/context-bounds.excludes
b/google-common/src/main/mima-filters/2.0.x.backwards.excludes/context-bounds.excludes
similarity index 75%
copy from
google-cloud-bigquery/src/main/mima-filters/2.0.x.backward.excludes/context-bounds.excludes
copy to
google-common/src/main/mima-filters/2.0.x.backwards.excludes/context-bounds.excludes
index a8b18fe12..7d72b1e30 100644
---
a/google-cloud-bigquery/src/main/mima-filters/2.0.x.backward.excludes/context-bounds.excludes
+++
b/google-common/src/main/mima-filters/2.0.x.backwards.excludes/context-bounds.excludes
@@ -18,5 +18,7 @@
# Converting context bound [T: FromResponseUnmarshaller] to explicit implicit
# parameter reorders the implicit parameter list at the bytecode level.
# This is a binary-incompatible change but does not affect source-level callers
-# using implicit resolution. BigQuery API is @ApiMayChange.
-ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.pekko.stream.connectors.googlecloud.bigquery.scaladsl.BigQuery.singleRequest")
+# (see #1682). MiMa 1.2.0 reports these on the trait and its companion object;
+# earlier MiMa versions only reported the equivalent problem in
google-cloud-bigquery.
+ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.stream.connectors.google.scaladsl.Google.singleRequest")
+ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.pekko.stream.connectors.google.scaladsl.Google.singleRequest")
diff --git a/project/plugins.sbt b/project/plugins.sbt
index 0bd7dfaca..da70affb3 100644
--- a/project/plugins.sbt
+++ b/project/plugins.sbt
@@ -17,7 +17,7 @@ addSbtPlugin("com.lightbend.sbt" % "sbt-bill-of-materials" %
"1.1.1")
// discipline
addSbtPlugin("com.github.sbt" % "sbt-header" % "5.11.0")
addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.6.2")
-addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.1.6")
+addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.2.0")
addSbtPlugin("com.github.sbt" % "sbt-java-formatter" % "0.13.1")
// docs
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
