This is an automated email from the ASF dual-hosted git repository.
pjfanning pushed a commit to branch main
in repository
https://gitbox.apache.org/repos/asf/pekko-persistence-cassandra.git
The following commit(s) were added to refs/heads/main by this push:
new c76c270 Update sbt-mima-plugin to 1.2.0 (#496)
c76c270 is described below
commit c76c2707a9279956bf1f666616f9ed1435fc6231
Author: Scala Steward <[email protected]>
AuthorDate: Tue Sep 8 23:14:31 2026 +0200
Update sbt-mima-plugin to 1.2.0 (#496)
* Update sbt-mima-plugin to 1.2.0
* Add MiMa excludes for sbt-mima-plugin 1.2.0
Motivation:
sbt-mima-plugin 1.2.0 detects incompatibilities against 1.0.0 that 1.1.6
did not report, so the `Check / Binary Compatibility` job fails on the
plugin bump.
Modification:
Add core/src/main/mima-filters/1.0.x.backwards.excludes/mima-1.2.0.excludes
covering the newly reported problems. All of them are in
TagWriter.TagWriterSettings and TaggedPreparedStatements, which are
@InternalApi private[pekko] and not part of the public API. Two of the
filters are only needed for the Scala 3 artifact.
Result:
MiMa passes against 1.0.0 for both Scala 2.13 and Scala 3 with
sbt-mima-plugin 1.2.0.
Tests:
- sbt "+core/mimaReportBinaryIssues" - success for 2.13.18 and 3.3.8
References:
Refs #496
---------
Co-authored-by: PJ Fanning <[email protected]>
---
.../1.0.x.backwards.excludes/mima-1.2.0.excludes | 41 ++++++++++++++++++++++
project/plugins.sbt | 2 +-
2 files changed, 42 insertions(+), 1 deletion(-)
diff --git
a/core/src/main/mima-filters/1.0.x.backwards.excludes/mima-1.2.0.excludes
b/core/src/main/mima-filters/1.0.x.backwards.excludes/mima-1.2.0.excludes
new file mode 100644
index 0000000..53d68b2
--- /dev/null
+++ b/core/src/main/mima-filters/1.0.x.backwards.excludes/mima-1.2.0.excludes
@@ -0,0 +1,41 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Pre-existing incompatibilities with 1.0.0 that only started being reported
+# once sbt-mima-plugin was upgraded from 1.1.6 to 1.2.0. Every affected class
+# is @InternalApi private[pekko], so none of them are part of the public API.
+
+# TagWriterSettings gained a maxBufferSize field (#478)
+ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.persistence.cassandra.journal.TagWriter#TagWriterSettings.copy")
+ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.pekko.persistence.cassandra.journal.TagWriter#TagWriterSettings.copy$default$2")
+ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.pekko.persistence.cassandra.journal.TagWriter#TagWriterSettings.copy$default$5")
+ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.persistence.cassandra.journal.TagWriter#TagWriterSettings.this")
+ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.cassandra.journal.TagWriter$TagWriterSettings$")
+ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.persistence.cassandra.journal.TagWriter#TagWriterSettings.apply")
+ProblemFilters.exclude[IncompatibleSignatureProblem]("org.apache.pekko.persistence.cassandra.journal.TagWriter#TagWriterSettings.unapply")
+# Scala 3 case class product accessors
+ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.pekko.persistence.cassandra.journal.TagWriter#TagWriterSettings._2")
+ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.pekko.persistence.cassandra.journal.TagWriter#TagWriterSettings._5")
+
+# TaggedPreparedStatements members are now RetryableFutureEval rather than
Future
+ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.pekko.persistence.cassandra.journal.TaggedPreparedStatements.WriteTagViewWithoutMeta")
+ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.pekko.persistence.cassandra.journal.TaggedPreparedStatements.WriteTagViewWithMeta")
+ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.pekko.persistence.cassandra.journal.TaggedPreparedStatements.WriteTagProgress")
+ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.pekko.persistence.cassandra.journal.TaggedPreparedStatements.SelectTagProgress")
+ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.pekko.persistence.cassandra.journal.TaggedPreparedStatements.SelectTagProgressForPersistenceId")
+ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.pekko.persistence.cassandra.journal.TaggedPreparedStatements.WriteTagScanning")
+ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.pekko.persistence.cassandra.journal.TaggedPreparedStatements.SelectTagScanningForPersistenceId")
diff --git a/project/plugins.sbt b/project/plugins.sbt
index 48ad738..6042f98 100644
--- a/project/plugins.sbt
+++ b/project/plugins.sbt
@@ -16,7 +16,7 @@ addSbtPlugin("com.github.sbt" % "sbt-multi-jvm" % "0.7.0")
addSbtPlugin("com.github.sbt" % "sbt-dynver" % "5.1.1")
addSbtPlugin("com.github.pjfanning" % "sbt-pekko-build" % "0.4.7")
addSbtPlugin("com.github.pjfanning" % "sbt-source-dist" % "0.2.0")
-addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.1.6")
+addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.2.0")
addSbtPlugin("net.bzzt" % "sbt-reproducible-builds" % "0.35")
// Documentation
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]