This is an automated email from the ASF dual-hosted git repository.

pjfanning pushed a commit to branch 1.4.x
in repository https://gitbox.apache.org/repos/asf/pekko-persistence-jdbc.git


The following commit(s) were added to refs/heads/1.4.x by this push:
     new 70006c2d Increase the migrator integration test patience timeout (#628)
70006c2d is described below

commit 70006c2d607dcfb02f8f7d6ef853e9dc1fd495bd
Author: PJ Fanning <[email protected]>
AuthorDate: Thu Sep 17 21:22:28 2026 +0100

    Increase the migrator integration test patience timeout (#628)
    
    The SQL Server migrator integration tests migrate 3000 legacy events with
    one insert per event and one per tag, all sequential, and on the GitHub
    runners that takes close to the 10 second PatienceConfig timeout. The
    "preserving tags" test timed out on
    https://github.com/apache/pekko-persistence-jdbc/pull/624 while the same
    test on 1.4.x an hour earlier passed at 17.9s total, so this is a flaky
    edge rather than a regression. Raise the timeout to 1 minute, matching
    the ask timeout.
    
    Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
---
 .../org/apache/pekko/persistence/jdbc/migrator/MigratorSpec.scala     | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git 
a/migrator-integration-test/src/test/scala/org/apache/pekko/persistence/jdbc/migrator/MigratorSpec.scala
 
b/migrator-integration-test/src/test/scala/org/apache/pekko/persistence/jdbc/migrator/MigratorSpec.scala
index 6af87016..f83373cf 100644
--- 
a/migrator-integration-test/src/test/scala/org/apache/pekko/persistence/jdbc/migrator/MigratorSpec.scala
+++ 
b/migrator-integration-test/src/test/scala/org/apache/pekko/persistence/jdbc/migrator/MigratorSpec.scala
@@ -40,7 +40,9 @@ abstract class MigratorSpec(val config: Config) extends 
SimpleSpec with BeforeAn
   // The db is initialized in the before and after each bocks
   var dbOpt: Option[Database] = None
 
-  implicit val pc: PatienceConfig = PatienceConfig(timeout = 10.seconds)
+  // migrating 3000 events is a few thousand sequential round trips to the 
database, which on the CI runners
+  // takes close to 10 seconds against SQL Server, so give the migration 
comfortably more time than that
+  implicit val pc: PatienceConfig = PatienceConfig(timeout = 1.minute)
   implicit val timeout: Timeout = Timeout(1.minute)
 
   private val logger: Logger = LoggerFactory.getLogger(this.getClass)


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to