Repository: phoenix Updated Branches: refs/heads/4.0 1cbe68f16 -> 6e5b4e11e
PHOENIX-1293 By default we should not disable wal for immutable indexes otherwise we end up in data loss on RS failure Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/6e5b4e11 Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/6e5b4e11 Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/6e5b4e11 Branch: refs/heads/4.0 Commit: 6e5b4e11ee68b89ef4d91b2c6a9d89823cefd13b Parents: 1cbe68f Author: Rajeshbabu Chintaguntla <rajeshbabu.chintagun...@huawei.com> Authored: Mon Sep 29 06:49:05 2014 +0530 Committer: Rajeshbabu Chintaguntla <rajeshbabu.chintagun...@huawei.com> Committed: Mon Sep 29 07:34:23 2014 +0530 ---------------------------------------------------------------------- .../src/main/java/org/apache/phoenix/schema/MetaDataClient.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/phoenix/blob/6e5b4e11/phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---------------------------------------------------------------------- diff --git a/phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java b/phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java index 5be8c3e..3b799bf 100644 --- a/phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java +++ b/phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java @@ -1060,9 +1060,7 @@ public class MetaDataClient { boolean disableWAL = false; Boolean disableWALProp = (Boolean) tableProps.remove(PhoenixDatabaseMetaData.DISABLE_WAL); - if (disableWALProp == null) { - disableWAL = isParentImmutableRows; // By default, disable WAL for immutable indexes - } else { + if (disableWALProp != null) { disableWAL = disableWALProp; } // Delay this check as it is supported to have IMMUTABLE_ROWS and SALT_BUCKETS defined on views
