Remove unused imports and local variables
Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/851f57a6 Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/851f57a6 Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/851f57a6 Branch: refs/heads/4.2 Commit: 851f57a6da1c91b02711d8974568206fb88ed49a Parents: 4c0d00b Author: James Taylor <[email protected]> Authored: Tue Oct 28 12:43:48 2014 -0700 Committer: James Taylor <[email protected]> Committed: Tue Oct 28 12:43:48 2014 -0700 ---------------------------------------------------------------------- .../apache/phoenix/trace/BaseTracingTestIT.java | 24 ++++++++++---------- .../apache/phoenix/trace/PhoenixTagImpl.java | 9 -------- .../org/apache/phoenix/trace/TracingUtils.java | 5 ---- 3 files changed, 12 insertions(+), 26 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/phoenix/blob/851f57a6/phoenix-core/src/it/java/org/apache/phoenix/trace/BaseTracingTestIT.java ---------------------------------------------------------------------- diff --git a/phoenix-core/src/it/java/org/apache/phoenix/trace/BaseTracingTestIT.java b/phoenix-core/src/it/java/org/apache/phoenix/trace/BaseTracingTestIT.java index f504d12..99c8bc3 100644 --- a/phoenix-core/src/it/java/org/apache/phoenix/trace/BaseTracingTestIT.java +++ b/phoenix-core/src/it/java/org/apache/phoenix/trace/BaseTracingTestIT.java @@ -17,8 +17,18 @@ */ package org.apache.phoenix.trace; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import static org.apache.phoenix.util.PhoenixRuntime.ANNOTATION_ATTRIB_PREFIX; +import static org.apache.phoenix.util.TestUtil.TEST_PROPERTIES; + +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.SQLException; +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.Properties; + import org.apache.hadoop.metrics2.AbstractMetric; import org.apache.hadoop.metrics2.MetricsInfo; import org.apache.hadoop.metrics2.MetricsRecord; @@ -38,22 +48,12 @@ import org.apache.phoenix.util.PropertiesUtil; import org.junit.Before; import org.junit.experimental.categories.Category; -import java.sql.Connection; -import java.sql.DriverManager; -import java.sql.SQLException; -import java.util.*; - -import static org.apache.phoenix.util.PhoenixRuntime.ANNOTATION_ATTRIB_PREFIX; -import static org.apache.phoenix.util.TestUtil.TEST_PROPERTIES; - /** * Base test for tracing tests - helps manage getting tracing/non-tracing * connections, as well as any supporting utils. */ @Category(HBaseManagedTimeTest.class) public class BaseTracingTestIT extends BaseHBaseManagedTimeIT { - private static final Log LOG = LogFactory.getLog(BaseTracingTestIT.class); - @Before public void resetTracingTableIfExists() throws Exception { Connection conn = getConnectionWithoutTracing(); http://git-wip-us.apache.org/repos/asf/phoenix/blob/851f57a6/phoenix-core/src/it/java/org/apache/phoenix/trace/PhoenixTagImpl.java ---------------------------------------------------------------------- diff --git a/phoenix-core/src/it/java/org/apache/phoenix/trace/PhoenixTagImpl.java b/phoenix-core/src/it/java/org/apache/phoenix/trace/PhoenixTagImpl.java index a911a2c..0d2def3 100644 --- a/phoenix-core/src/it/java/org/apache/phoenix/trace/PhoenixTagImpl.java +++ b/phoenix-core/src/it/java/org/apache/phoenix/trace/PhoenixTagImpl.java @@ -17,22 +17,13 @@ */ package org.apache.phoenix.trace; -import org.apache.hadoop.metrics2.MetricsInfo; import org.apache.hadoop.metrics2.MetricsTag; /** * Simple Tag implementation for testing */ public class PhoenixTagImpl extends MetricsTag { - - private final String name; - private final String description; - private final String value; - public PhoenixTagImpl(String name, String description, String value) { super(new MetricsInfoImpl(name, description), value); - this.name = name; - this.description = description; - this.value = value; } } \ No newline at end of file http://git-wip-us.apache.org/repos/asf/phoenix/blob/851f57a6/phoenix-core/src/main/java/org/apache/phoenix/trace/TracingUtils.java ---------------------------------------------------------------------- diff --git a/phoenix-core/src/main/java/org/apache/phoenix/trace/TracingUtils.java b/phoenix-core/src/main/java/org/apache/phoenix/trace/TracingUtils.java index 6ae52d8..cee3b95 100644 --- a/phoenix-core/src/main/java/org/apache/phoenix/trace/TracingUtils.java +++ b/phoenix-core/src/main/java/org/apache/phoenix/trace/TracingUtils.java @@ -17,8 +17,6 @@ */ package org.apache.phoenix.trace; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; import org.apache.hadoop.hbase.util.Bytes; import org.apache.hadoop.hbase.util.Pair; import org.cloudera.htrace.Span; @@ -27,9 +25,6 @@ import org.cloudera.htrace.Span; * Utilities for tracing */ public class TracingUtils { - - private static final Log LOG = LogFactory.getLog(TracingUtils.class); - public static final String METRIC_SOURCE_KEY = "phoenix."; /** Set context to enable filtering */
