Repository: phoenix
Updated Branches:
  refs/heads/4.x-HBase-0.98 f57a97a08 -> 8182ee32a


PHOENIX-3853 Local Index - Writes to local index are twice as slow as global 
and get exponentially slower with PHOENIX-3827_v2 patch(Rajeshbabu)


Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo
Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/8182ee32
Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/8182ee32
Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/8182ee32

Branch: refs/heads/4.x-HBase-0.98
Commit: 8182ee32a2c08f2ff428fabcb68c2803a0b038ec
Parents: f57a97a
Author: Rajeshbabu Chintaguntla <[email protected]>
Authored: Wed May 24 15:03:43 2017 +0530
Committer: Rajeshbabu Chintaguntla <[email protected]>
Committed: Wed May 24 15:03:43 2017 +0530

----------------------------------------------------------------------
 .../org/apache/phoenix/hbase/index/Indexer.java | 25 ++++----------------
 1 file changed, 5 insertions(+), 20 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/phoenix/blob/8182ee32/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java
----------------------------------------------------------------------
diff --git 
a/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java 
b/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java
index 748779f..22facd4 100644
--- a/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java
+++ b/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java
@@ -96,6 +96,11 @@ import com.google.common.collect.Multimap;
  * nothing does. Currently, we do not support mixed-durability updates within 
a single batch. If you
  * want to have different durability levels, you only need to split the 
updates into two different
  * batches.
+ * <p>
+ * We don't need to implement {@link #postPut(ObserverContext, Put, WALEdit, 
Durability)} and
+ * {@link #postDelete(ObserverContext, Delete, WALEdit, Durability)} hooks 
because
+ * Phoenix always does batch mutations.
+ * <p>
  */
 public class Indexer extends BaseRegionObserver {
 
@@ -366,26 +371,6 @@ public class Indexer extends BaseRegionObserver {
   }
 
   @Override
-  public void postPut(ObserverContext<RegionCoprocessorEnvironment> e, Put 
put, WALEdit edit,
-      final Durability durability) throws IOException {
-      if (this.disabled) {
-      super.postPut(e, put, edit, durability);
-          return;
-        }
-    doPost(edit, put, durability);
-  }
-
-  @Override
-  public void postDelete(ObserverContext<RegionCoprocessorEnvironment> e, 
Delete delete,
-      WALEdit edit, final Durability durability) throws IOException {
-      if (this.disabled) {
-      super.postDelete(e, delete, edit, durability);
-          return;
-        }
-    doPost(edit, delete, durability);
-  }
-
-  @Override
   public void 
postBatchMutateIndispensably(ObserverContext<RegionCoprocessorEnvironment> c,
       MiniBatchOperationInProgress<Mutation> miniBatchOp, final boolean 
success) throws IOException {
       if (this.disabled) {

Reply via email to