[phoenix] branch master updated: PHOENIX-4893 Move parent column combining logic of view and view indexes from server to client (addendum)

[tdsilva]

This is an automated email from the ASF dual-hosted git repository.

tdsilva pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/phoenix.git


The following commit(s) were added to refs/heads/master by this push:
     new 62387ee  PHOENIX-4893 Move parent column combining logic of view and 
view indexes from server to client (addendum)
62387ee is described below

commit 62387ee3c55f8be1947161bc9d501b1867cc24f1
Author: Thomas D'Silva <tdsi...@apache.org>
AuthorDate: Mon Jul 22 22:41:47 2019 -0700

    PHOENIX-4893 Move parent column combining logic of view and view indexes 
from server to client (addendum)
---
 .../org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java   | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git 
a/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
 
b/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
index 6457185..9c2e05f 100644
--- 
a/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
+++ 
b/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
@@ -2640,6 +2640,16 @@ public class MetaDataEndpointImpl extends 
MetaDataProtocol implements RegionCopr
                 }
             } finally {
                 ServerUtil.releaseRowLocks(locks);
+                // drop indexes on views that require the column being dropped
+                // these could be on a different region server so don't hold 
row locks while dropping them
+                for (Pair<PTable, PColumn> pair : 
mutator.getTableAndDroppedColumnPairs()) {
+                    result = dropRemoteIndexes(env, pair.getFirst(), 
clientTimeStamp, pair.getSecond(),
+                            tableNamesToDelete, sharedTablesToDelete);
+                    if (result != null
+                            && result.getMutationCode() != 
MutationCode.TABLE_ALREADY_EXISTS) {
+                        return result;
+                    }
+                }
             }
         } catch (Throwable t) {
             ServerUtil.throwIOException(fullTableName, t);