This is an automated email from the ASF dual-hosted git repository.
vjasani pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/phoenix.git
The following commit(s) were added to refs/heads/master by this push:
new ca21a87dd6 PHOENIX-7394 MaxPhoenixColumnSizeExceededException should
not print rowkey (#1961)
ca21a87dd6 is described below
commit ca21a87dd66b489bd80dcd6eb7c3f1ece766b6c7
Author: Jing Yu <[email protected]>
AuthorDate: Thu Aug 29 11:14:26 2024 -0700
PHOENIX-7394 MaxPhoenixColumnSizeExceededException should not print rowkey
(#1961)
---
.../org/apache/phoenix/compile/UpsertCompiler.java | 25 +++++-----------------
.../MaxPhoenixColumnSizeExceededException.java | 4 ++--
.../apache/phoenix/end2end/MutationStateIT.java | 6 ------
3 files changed, 7 insertions(+), 28 deletions(-)
diff --git
a/phoenix-core-client/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java
b/phoenix-core-client/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java
index e9ff7d15e4..5529ec08af 100644
---
a/phoenix-core-client/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java
+++
b/phoenix-core-client/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java
@@ -146,9 +146,8 @@ public class UpsertCompiler {
PColumn column = table.getColumns().get(columnIndexes[i]);
if (value.length >= maxHBaseClientKeyValueSize &&
table.getImmutableStorageScheme() ==
PTable.ImmutableStorageScheme.ONE_CELL_PER_COLUMN) {
- String rowkeyAndColumnInfo =
getExceedMaxHBaseClientKeyValueAllowanceRowkeyAndColumnInfo(
- values, columnIndexes, table, numSplColumns,
column.getName().getString());
- throw new
MaxPhoenixColumnSizeExceededException(rowkeyAndColumnInfo,
maxHBaseClientKeyValueSize, value.length);
+ String columnInfo =
getExceedMaxHBaseClientKeyValueAllowanceColumnInfo(table,
column.getName().getString());
+ throw new MaxPhoenixColumnSizeExceededException(columnInfo,
maxHBaseClientKeyValueSize, value.length);
}
if (SchemaUtil.isPKColumn(column)) {
@@ -187,24 +186,10 @@ public class UpsertCompiler {
mutation.put(ptr, new RowMutationState(columnValues, columnValueSize,
statement.getConnection().getStatementExecutionCounter(), rowTsColInfo,
onDupKeyBytes));
}
- public static String
getExceedMaxHBaseClientKeyValueAllowanceRowkeyAndColumnInfo(
- byte[][] values, int[] columnIndexes, PTable table, int
numSplColumns, String columnName) {
- StringBuilder sb = new StringBuilder();
- for (int i = 0, j = numSplColumns; j < values.length; j++, i++) {
- byte[] value = values[j];
- PColumn column = table.getColumns().get(columnIndexes[i]);
- if (SchemaUtil.isPKColumn(column)) {
- if (sb.length() != 0) {
- sb.append(" AND ");
- }
- sb.append(column.getName().toString() + "=" +
Bytes.toString(value));
- }
- }
- return String.format("Upsert data to table %s on Column %s exceed max
HBase client keyvalue size allowance, " +
- "the rowkey is %s",
+ public static String
getExceedMaxHBaseClientKeyValueAllowanceColumnInfo(PTable table, String
columnName) {
+ return String.format("Upsert data to table %s on Column %s exceed max
HBase client keyvalue size allowance",
SchemaUtil.getTableName(table.getSchemaName().toString(),
table.getTableName().toString()),
- columnName,
- sb.toString());
+ columnName);
}
public static MutationState upsertSelect(StatementContext childContext,
TableRef tableRef,
diff --git
a/phoenix-core-client/src/main/java/org/apache/phoenix/schema/MaxPhoenixColumnSizeExceededException.java
b/phoenix-core-client/src/main/java/org/apache/phoenix/schema/MaxPhoenixColumnSizeExceededException.java
index dc73145c26..64e01d5eae 100644
---
a/phoenix-core-client/src/main/java/org/apache/phoenix/schema/MaxPhoenixColumnSizeExceededException.java
+++
b/phoenix-core-client/src/main/java/org/apache/phoenix/schema/MaxPhoenixColumnSizeExceededException.java
@@ -37,10 +37,10 @@ public class MaxPhoenixColumnSizeExceededException extends
SQLException {
super(new SQLExceptionInfo.Builder(code).build().toString(),
code.getSQLState(), code.getErrorCode(), null);
}
- public MaxPhoenixColumnSizeExceededException(String rowkeyAndColumnInfo,
int maxMutationCellSizeBytes,
+ public MaxPhoenixColumnSizeExceededException(String columnInfo, int
maxMutationCellSizeBytes,
int mutationCellSizeBytes) {
super(new
SQLExceptionInfo.Builder(code).setMaxPhoenixColumnSizeBytes(maxMutationCellSizeBytes)
-
.setPhoenixColumnSizeBytes(mutationCellSizeBytes).build().toString() + ". " +
rowkeyAndColumnInfo,
+
.setPhoenixColumnSizeBytes(mutationCellSizeBytes).build().toString() + ". " +
columnInfo,
code.getSQLState(), code.getErrorCode(), null);
}
}
\ No newline at end of file
diff --git
a/phoenix-core/src/it/java/org/apache/phoenix/end2end/MutationStateIT.java
b/phoenix-core/src/it/java/org/apache/phoenix/end2end/MutationStateIT.java
index 41d2395e3f..6ca3c0de7a 100644
--- a/phoenix-core/src/it/java/org/apache/phoenix/end2end/MutationStateIT.java
+++ b/phoenix-core/src/it/java/org/apache/phoenix/end2end/MutationStateIT.java
@@ -616,12 +616,6 @@ public class MutationStateIT extends
ParallelStatsDisabledIT {
SQLExceptionCode.MAX_HBASE_CLIENT_KEYVALUE_MAXSIZE_EXCEEDED.getMessage()));
assertTrue(e.getMessage().contains(
connectionProperties.getProperty(QueryServices.HBASE_CLIENT_KEYVALUE_MAXSIZE)));
- assertTrue(e.getMessage().contains(pk1Name));
- assertTrue(e.getMessage().contains(pk2Name));
- assertTrue(e.getMessage().contains(pk1Value));
- assertTrue(e.getMessage().contains(pk2Value));
- assertFalse(e.getMessage().contains(payload1Value));
- assertFalse(e.getMessage().contains(payload3Value));
}
}
}
