This is an automated email from the ASF dual-hosted git repository. virajjasani pushed a commit to branch 5.3 in repository https://gitbox.apache.org/repos/asf/phoenix.git
commit 5b79edda038f2558997f42cc429c150f85e9761f Author: Palash Chauhan <[email protected]> AuthorDate: Fri Jul 17 10:55:38 2026 -0700 PHOENIX-7816 spotless addendum (#2578) --- .../phoenix/end2end/UCFWithDisabledIndexIT.java | 6 ++--- .../java/org/apache/phoenix/rpc/UpdateCacheIT.java | 29 +++++++++++----------- 2 files changed, 17 insertions(+), 18 deletions(-) diff --git a/phoenix-core/src/it/java/org/apache/phoenix/end2end/UCFWithDisabledIndexIT.java b/phoenix-core/src/it/java/org/apache/phoenix/end2end/UCFWithDisabledIndexIT.java index 6290c5d199..6d097ef5e9 100644 --- a/phoenix-core/src/it/java/org/apache/phoenix/end2end/UCFWithDisabledIndexIT.java +++ b/phoenix-core/src/it/java/org/apache/phoenix/end2end/UCFWithDisabledIndexIT.java @@ -105,7 +105,8 @@ public class UCFWithDisabledIndexIT extends BaseTest { } - private static void waitForCoprocessorOnSystemCatalog(Class<?> coprocessorClass) throws Exception { + private static void waitForCoprocessorOnSystemCatalog(Class<?> coprocessorClass) + throws Exception { final TableName sysCatalog = TableName.valueOf("SYSTEM.CATALOG"); utility.waitFor(10000, 100, () -> { List<HRegion> regions = utility.getHBaseCluster().getRegions(sysCatalog); @@ -113,8 +114,7 @@ public class UCFWithDisabledIndexIT extends BaseTest { return false; } for (HRegion region : regions) { - if (region.getCoprocessorHost() - .findCoprocessor(coprocessorClass.getName()) == null) { + if (region.getCoprocessorHost().findCoprocessor(coprocessorClass.getName()) == null) { return false; } } diff --git a/phoenix-core/src/it/java/org/apache/phoenix/rpc/UpdateCacheIT.java b/phoenix-core/src/it/java/org/apache/phoenix/rpc/UpdateCacheIT.java index 1af5a3b512..394a3cbca7 100644 --- a/phoenix-core/src/it/java/org/apache/phoenix/rpc/UpdateCacheIT.java +++ b/phoenix-core/src/it/java/org/apache/phoenix/rpc/UpdateCacheIT.java @@ -66,22 +66,21 @@ import org.apache.phoenix.thirdparty.com.google.common.util.concurrent.ThreadFac /** * Verifies the number of RPC calls from {@link MetaDataClient} updateCache() for transactional and * non-transactional tables. - * - * <p>Categorized as {@link NeedsOwnMiniClusterTest} so failsafe runs this class in its own forked - * JVM (reuseForks=false). The {@link #helpTestUpdateCache} helper wraps the JVM-singleton + * <p> + * Categorized as {@link NeedsOwnMiniClusterTest} so failsafe runs this class in its own forked JVM + * (reuseForks=false). The {@link #helpTestUpdateCache} helper wraps the JVM-singleton * {@link ConnectionQueryServices} returned by {@code driver.getConnectionQueryServices(...)} in a - * Mockito spy. Because the Phoenix driver caches that CQS as a process-global singleton and the - * spy delegates to the real instance with {@code this} bound to the spy, every internal Phoenix - * call back through the services field is recorded in the spy's {@code InvocationContainerImpl}, - * holding strong references to all arguments. Under the {@code ParallelStatsDisabledTest} - * execution ({@code reuseForks=true}) this class previously ran in a fork that had already - * accumulated thousands of tests' worth of cached metadata, regions, and live ZK clients on the - * same singleton; combined with the spy's invocation-history retention, the fork was tipping over - * with {@code OutOfMemoryError: Java heap space} (5.8 GB heap dump from the ZK - * {@code main-SendThread}) on {@link #testUpdateCacheForNonTxnTable}. Running in its own JVM - * gives the test a fresh CQS singleton with no cross-test accumulation. This follows the same - * convention as {@code MetaDataEndPointIT} and other singleton-state-sensitive tests in this - * project. + * Mockito spy. Because the Phoenix driver caches that CQS as a process-global singleton and the spy + * delegates to the real instance with {@code this} bound to the spy, every internal Phoenix call + * back through the services field is recorded in the spy's {@code InvocationContainerImpl}, holding + * strong references to all arguments. Under the {@code ParallelStatsDisabledTest} execution + * ({@code reuseForks=true}) this class previously ran in a fork that had already accumulated + * thousands of tests' worth of cached metadata, regions, and live ZK clients on the same singleton; + * combined with the spy's invocation-history retention, the fork was tipping over with + * {@code OutOfMemoryError: Java heap space} (5.8 GB heap dump from the ZK {@code main-SendThread}) + * on {@link #testUpdateCacheForNonTxnTable}. Running in its own JVM gives the test a fresh CQS + * singleton with no cross-test accumulation. This follows the same convention as + * {@code MetaDataEndPointIT} and other singleton-state-sensitive tests in this project. */ @Category(NeedsOwnMiniClusterTest.class) public class UpdateCacheIT extends ParallelStatsDisabledIT {
