This is an automated email from the ASF dual-hosted git repository.

snlee pushed a commit to branch improve-bloomfilter-indexing-config
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git

commit ab974fa17afa66e8b14fdc630480e87faaa5638a
Author: Seunghyun Lee <[email protected]>
AuthorDate: Thu Dec 6 14:25:53 2018 -0800

    Add the bloom filter to equals() and hashCode() in IndexingConfig
---
 .../main/java/com/linkedin/pinot/common/config/IndexingConfig.java  | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git 
a/pinot-common/src/main/java/com/linkedin/pinot/common/config/IndexingConfig.java
 
b/pinot-common/src/main/java/com/linkedin/pinot/common/config/IndexingConfig.java
index 35de1e3..c3a45900 100644
--- 
a/pinot-common/src/main/java/com/linkedin/pinot/common/config/IndexingConfig.java
+++ 
b/pinot-common/src/main/java/com/linkedin/pinot/common/config/IndexingConfig.java
@@ -116,7 +116,7 @@ public class IndexingConfig {
     _sortedColumn = sortedColumn;
   }
 
-  
+
   public List<String> getBloomFilterColumns() {
     return _bloomFilterColumns;
   }
@@ -275,7 +275,8 @@ public class IndexingConfig {
         .isEqual(_noDictionaryColumns, that._noDictionaryColumns) && 
EqualityUtils.isEqual(_noDictionaryConfig,
         that._noDictionaryConfig) && 
EqualityUtils.isEqual(_onHeapDictionaryColumns, that._onHeapDictionaryColumns)
         && EqualityUtils.isEqual(_starTreeIndexSpec, that._starTreeIndexSpec) 
&& EqualityUtils.isEqual(
-        _segmentPartitionConfig, that._segmentPartitionConfig);
+        _segmentPartitionConfig, that._segmentPartitionConfig) && 
EqualityUtils.isEqual(_bloomFilterColumns,
+        that._bloomFilterColumns);
   }
 
   @Override
@@ -293,6 +294,7 @@ public class IndexingConfig {
     result = EqualityUtils.hashCodeOf(result, _onHeapDictionaryColumns);
     result = EqualityUtils.hashCodeOf(result, _starTreeIndexSpec);
     result = EqualityUtils.hashCodeOf(result, _segmentPartitionConfig);
+    result = EqualityUtils.hashCodeOf(result, _bloomFilterColumns);
     return result;
   }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to