[incubator-pinot] branch periodic_task_order updated: Lower access modifier for overriden methods

[nehapawar]

This is an automated email from the ASF dual-hosted git repository.

nehapawar pushed a commit to branch periodic_task_order
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/periodic_task_order by this 
push:
     new 815b120  Lower access modifier for overriden methods
815b120 is described below

commit 815b120c00442c108485e81007be29dc4e6b00ad
Author: Neha Pawar <npa...@linkedin.com>
AuthorDate: Tue Dec 18 14:05:30 2018 -0800

    Lower access modifier for overriden methods
---
 .../com/linkedin/pinot/controller/helix/SegmentStatusChecker.java   | 6 +++---
 .../pinot/controller/helix/core/minion/PinotTaskManager.java        | 2 +-
 .../controller/helix/core/periodictask/ControllerPeriodicTask.java  | 2 +-
 .../com/linkedin/pinot/controller/validation/ValidationManager.java | 6 +++---
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git 
a/pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/SegmentStatusChecker.java
 
b/pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/SegmentStatusChecker.java
index d444e67..191a902 100644
--- 
a/pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/SegmentStatusChecker.java
+++ 
b/pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/SegmentStatusChecker.java
@@ -90,7 +90,7 @@ public class SegmentStatusChecker extends 
ControllerPeriodicTask {
   }
 
   @Override
-  public void preprocess() {
+  protected void preprocess() {
     _realTimeTableCount = 0;
     _offlineTableCount = 0;
     _disabledTableCount = 0;
@@ -106,12 +106,12 @@ public class SegmentStatusChecker extends 
ControllerPeriodicTask {
   }
 
   @Override
-  public void process(String tableNameWithType) {
+  protected void process(String tableNameWithType) {
     updateSegmentMetrics(tableNameWithType);
   }
 
   @Override
-  public void postprocess() {
+  protected void postprocess() {
     
_metricsRegistry.setValueOfGlobalGauge(ControllerGauge.REALTIME_TABLE_COUNT, 
_realTimeTableCount);
     
_metricsRegistry.setValueOfGlobalGauge(ControllerGauge.OFFLINE_TABLE_COUNT, 
_offlineTableCount);
     
_metricsRegistry.setValueOfGlobalGauge(ControllerGauge.DISABLED_TABLE_COUNT, 
_disabledTableCount);
diff --git 
a/pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/minion/PinotTaskManager.java
 
b/pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/minion/PinotTaskManager.java
index d1ebd96..507a6f1 100644
--- 
a/pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/minion/PinotTaskManager.java
+++ 
b/pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/minion/PinotTaskManager.java
@@ -160,7 +160,7 @@ public class PinotTaskManager extends 
ControllerPeriodicTask {
    * Returns the tasks that have been scheduled as part of the postprocess
    * @return
    */
-  public Map<String, String> getTasksScheduled() {
+  private Map<String, String> getTasksScheduled() {
     return _tasksScheduled;
   }
 }
diff --git 
a/pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java
 
b/pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java
index 9ce5c59..a370695 100644
--- 
a/pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java
+++ 
b/pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java
@@ -124,7 +124,7 @@ public abstract class ControllerPeriodicTask extends 
BasePeriodicTask {
   protected abstract void preprocess();
 
   /**
-   * Process the controller periodic task for the given table
+   * Execute the controller periodic task for the given table
    * @param tableNameWithType
    */
   protected abstract void process(String tableNameWithType);
diff --git 
a/pinot-controller/src/main/java/com/linkedin/pinot/controller/validation/ValidationManager.java
 
b/pinot-controller/src/main/java/com/linkedin/pinot/controller/validation/ValidationManager.java
index b9b775d..24ead61 100644
--- 
a/pinot-controller/src/main/java/com/linkedin/pinot/controller/validation/ValidationManager.java
+++ 
b/pinot-controller/src/main/java/com/linkedin/pinot/controller/validation/ValidationManager.java
@@ -76,7 +76,7 @@ public class ValidationManager extends ControllerPeriodicTask 
{
   }
 
   @Override
-  public void preprocess() {
+  protected void preprocess() {
     // Run segment level validation using a separate interval
     _runSegmentLevelValidation = false;
     long currentTimeMs = System.currentTimeMillis();
@@ -92,12 +92,12 @@ public class ValidationManager extends 
ControllerPeriodicTask {
   }
 
   @Override
-  public void process(String tableNameWithType) {
+  protected void process(String tableNameWithType) {
     runValidation(tableNameWithType);
   }
 
   @Override
-  public void postprocess() {
+  protected void postprocess() {
 
   }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org