This is an automated email from the ASF dual-hosted git repository.
apucher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 969e471 [TE] frontend - harleyjj/home - make email share available
even when there are no anomalies (#3632)
969e471 is described below
commit 969e4714ac3c5fbf192fcc0040ffbef4bd22f622
Author: Harley Jackson <[email protected]>
AuthorDate: Tue Jan 8 10:16:39 2019 -0800
[TE] frontend - harleyjj/home - make email share available even when there
are no anomalies (#3632)
---
thirdeye/thirdeye-frontend/app/pods/home/index/template.hbs | 2 +-
thirdeye/thirdeye-frontend/app/pods/home/share-dashboard/route.js | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/thirdeye/thirdeye-frontend/app/pods/home/index/template.hbs
b/thirdeye/thirdeye-frontend/app/pods/home/index/template.hbs
index 674f337..fbe5c12 100644
--- a/thirdeye/thirdeye-frontend/app/pods/home/index/template.hbs
+++ b/thirdeye/thirdeye-frontend/app/pods/home/index/template.hbs
@@ -10,7 +10,7 @@
predefinedRanges=pill.predefinedRanges
selectAction=(action "onRangeSelection")
}}
- {{#if (gt anomaliesCount 0)}}
+ {{#if appName}}
{{#link-to "home.share-dashboard" (query-params appName=appName
duration=duration startDate=startDate endDate=endDate feedbackType=feedbackType
shareId=null) tagName="button" type="button" class="pull-right te-button
te-button--outline"}}
Share
{{/link-to}}
diff --git a/thirdeye/thirdeye-frontend/app/pods/home/share-dashboard/route.js
b/thirdeye/thirdeye-frontend/app/pods/home/share-dashboard/route.js
index 6f4f751..a3b3625 100644
--- a/thirdeye/thirdeye-frontend/app/pods/home/share-dashboard/route.js
+++ b/thirdeye/thirdeye-frontend/app/pods/home/share-dashboard/route.js
@@ -9,7 +9,6 @@ import columns from
'thirdeye-frontend/shared/anomaliesTableColumnsShared';
import {
get,
set,
- computed,
setProperties
} from '@ember/object';
@@ -32,8 +31,8 @@ export default Route.extend(AuthenticatedRouteMixin, {
},
appName: null,
startDate: moment().subtract(1, 'day').utc().valueOf(), //taylored for Last
24 hours vs Today -> moment().startOf('day').utc().valueOf(),
- endDate: moment().utc().valueOf(),//Last 24 hours
- duration: '1d',//Last 24 hours
+ endDate: moment().utc().valueOf(), //Last 24 hours
+ duration: '1d', //Last 24 hours
feedbackType: 'All Resolutions',
shareId: null,
@@ -108,7 +107,6 @@ export default Route.extend(AuthenticatedRouteMixin, {
applicationAnomalies.forEach(anomaly => {
const metricName = get(anomaly, 'metricName');
const metricId = get(anomaly, 'metricId');
- const id = get(anomaly, 'id');
const functionName = get(anomaly, 'functionName');
const functionId = get(anomaly, 'functionId');
//Grouping the anomalies of the same metric name
@@ -140,7 +138,7 @@ export default Route.extend(AuthenticatedRouteMixin, {
this.controller.setProperties({
'shareId': null,
'showTooltip': false,
- 'shareUrl': null,
+ 'shareUrl': null
});
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
