This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch pinotfs-copy-ensure-parent-dir-exist in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 2cac00750969b604a3c4fbbba1da94db4001070a Author: Jack Li(Analytics Engineering) <[email protected]> AuthorDate: Tue Jan 8 10:31:22 2019 -0800 Add unit tests for copying file/dir to a non-existent file --- .../pinot/filesystem/LocalPinotFSTest.java | 25 +++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/pinot-filesystem/src/test/java/com/linkedin/pinot/filesystem/LocalPinotFSTest.java b/pinot-filesystem/src/test/java/com/linkedin/pinot/filesystem/LocalPinotFSTest.java index 81a4800..665aa2d 100644 --- a/pinot-filesystem/src/test/java/com/linkedin/pinot/filesystem/LocalPinotFSTest.java +++ b/pinot-filesystem/src/test/java/com/linkedin/pinot/filesystem/LocalPinotFSTest.java @@ -134,7 +134,7 @@ public class LocalPinotFSTest { Assert.assertEquals(_newTmpDir.listFiles().length, files); Assert.assertFalse(dstFile.exists()); - // Check that a moving a file a non-existent destination folder will work + // Check that copying a file to a non-existent destination folder will work FileUtils.deleteQuietly(_nonExistentTmpFolder); Assert.assertFalse(_nonExistentTmpFolder.exists()); File srcFile = new File(_absoluteTmpDirPath, "srcFile"); @@ -142,6 +142,29 @@ public class LocalPinotFSTest { Assert.assertTrue(srcFile.createNewFile()); dstFile = new File(_nonExistentTmpFolder.getPath() + "/newFile" ); Assert.assertFalse(dstFile.exists()); + Assert.assertTrue(localPinotFS.copy(srcFile.toURI(), dstFile.toURI())); + Assert.assertTrue(srcFile.exists()); + Assert.assertTrue(dstFile.exists()); + + //Check that copying a folder to a non-existent destination folder works + FileUtils.deleteQuietly(_nonExistentTmpFolder); + Assert.assertFalse(_nonExistentTmpFolder.exists()); + localPinotFS.mkdir(_absoluteTmpDirPath.toURI()); + dstFile = new File(_nonExistentTmpFolder.getPath() + "/srcFile" ); + Assert.assertFalse(dstFile.exists()); + Assert.assertTrue(localPinotFS.copy(_absoluteTmpDirPath.toURI(), _nonExistentTmpFolder.toURI())); + Assert.assertTrue(dstFile.exists()); + FileUtils.deleteQuietly(srcFile); + Assert.assertFalse(srcFile.exists()); + + // Check that moving a file to a non-existent destination folder will work + FileUtils.deleteQuietly(_nonExistentTmpFolder); + Assert.assertFalse(_nonExistentTmpFolder.exists()); + srcFile = new File(_absoluteTmpDirPath, "srcFile"); + localPinotFS.mkdir(_absoluteTmpDirPath.toURI()); + Assert.assertTrue(srcFile.createNewFile()); + dstFile = new File(_nonExistentTmpFolder.getPath() + "/newFile" ); + Assert.assertFalse(dstFile.exists()); Assert.assertTrue(localPinotFS.move(srcFile.toURI(), dstFile.toURI(), true)); // overwrite flag has no impact Assert.assertFalse(srcFile.exists()); Assert.assertTrue(dstFile.exists()); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
