This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a commit to branch access-denied-log in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 29bf13c2f31baf9d69bdf3da58fbf0e77823ac70 Author: Subbu Subramaniam <[email protected]> AuthorDate: Wed Jan 9 13:36:05 2019 -0800 Added a log when access is denied --- .../pinot/broker/requesthandler/BaseBrokerRequestHandler.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pinot-broker/src/main/java/com/linkedin/pinot/broker/requesthandler/BaseBrokerRequestHandler.java b/pinot-broker/src/main/java/com/linkedin/pinot/broker/requesthandler/BaseBrokerRequestHandler.java index ea8eb0e..2b9304d 100644 --- a/pinot-broker/src/main/java/com/linkedin/pinot/broker/requesthandler/BaseBrokerRequestHandler.java +++ b/pinot-broker/src/main/java/com/linkedin/pinot/broker/requesthandler/BaseBrokerRequestHandler.java @@ -107,7 +107,7 @@ public abstract class BaseBrokerRequestHandler implements BrokerRequestHandler { return ""; } } - + @Override public BrokerResponse handleRequest(JSONObject request, @Nullable RequesterIdentity requesterIdentity) throws Exception { @@ -149,8 +149,8 @@ public abstract class BaseBrokerRequestHandler implements BrokerRequestHandler { // Check table access boolean hasAccess = _accessControlFactory.create().hasAccess(requesterIdentity, brokerRequest); if (!hasAccess) { - _brokerMetrics.addMeteredTableValue(brokerRequest.getQuerySource().getTableName(), - BrokerMeter.REQUEST_DROPPED_DUE_TO_ACCESS_ERROR, 1); + _brokerMetrics.addMeteredTableValue(tableName, BrokerMeter.REQUEST_DROPPED_DUE_TO_ACCESS_ERROR, 1); + LOGGER.info("Access denied for requestId {}, table {}", requestId, tableName); requestStatistics.setErrorCode(QueryException.ACCESS_DENIED_ERROR_CODE); return new BrokerResponseNative(QueryException.ACCESS_DENIED_ERROR); } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
