WangGuangxin commented on a change in pull request #3852: add support for
parquet reader
URL: https://github.com/apache/incubator-pinot/pull/3852#discussion_r257922035
##########
File path: pinot-core/pom.xml
##########
@@ -213,5 +213,32 @@
<groupId>org.apache.commons</groupId>
<artifactId>commons-math</artifactId>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.parquet</groupId>
+ <artifactId>parquet-avro</artifactId>
+ <version>${parquet.version}</version>
+ </dependency>
+
+ <dependency>
Review comment:
> Hadoop brings a lot of dependencies. Its better to avoid pulling in those
dependencies Is there a way to get the schema without depending on Hadoop libs?
>
> If we have to depend on Hadoop then its better to add code into
pinot-hadoop module?
I'v refactored code, put parquet related codes in `ParquetUtils.java`, which
locates in `pinot-common`, since it already has `hadoop-client` dependency.
I didn't move it to `pinot-hadoop` because there'll be cross reference
between `pinot-core` and `pinot-hadoop`.
Now, `pinot-core` needs `hadoop-client` only in test scope. Is that ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
