mayankshriv commented on a change in pull request #3868: Disable realtime
aggregate metrics if multi value dimension present
URL: https://github.com/apache/incubator-pinot/pull/3868#discussion_r259552728
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -668,6 +668,7 @@ private int getOrCreateDocId(Map<String, Object>
dictIdMap) {
int i = 0;
int[] dictIds = new int[_numKeyColumns]; // dimensions + time column.
+ // TODO: this for loop breaks for multi value columns.
https://github.com/apache/incubator-pinot/issues/3867
Review comment:
No, this TODO is to make the actual support for MV dimensions in RT
aggregation of metrics. This PR is just disabling it in presence of MV columns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
