mcvsubbu commented on a change in pull request #3868: Disable realtime
aggregate metrics if multi value columns present
URL: https://github.com/apache/incubator-pinot/pull/3868#discussion_r259554179
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -668,6 +668,7 @@ private int getOrCreateDocId(Map<String, Object>
dictIdMap) {
int i = 0;
int[] dictIds = new int[_numKeyColumns]; // dimensions + time column.
+ // TODO: this for loop breaks for multi value columns.
https://github.com/apache/incubator-pinot/issues/3867
Review comment:
well, as the code stands it will never break since we disable if we have MV
dimensions...but that is my ocd i guess :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
