This is an automated email from the ASF dual-hosted git repository.
akshayrai09 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new de950ff [TE] Update label and detection description (#3878)
de950ff is described below
commit de950fffb1eb9e9ab5bceb9776c5ae6a31a00d53
Author: Akshay Rai <[email protected]>
AuthorDate: Mon Feb 25 14:34:21 2019 -0800
[TE] Update label and detection description (#3878)
---
.../thirdeye-frontend/app/pods/components/yaml-editor/template.hbs | 2 +-
.../apache/pinot/thirdeye/detection/DetectionMigrationResource.java | 2 +-
.../pinot/thirdeye/detection/LegacyAnomalyFunctionTranslator.java | 2 +-
.../apache/pinot/thirdeye/detection/migrated-detection-config-1.json | 4 ++--
.../apache/pinot/thirdeye/detection/migrated-detection-config-2.json | 4 ++--
5 files changed, 7 insertions(+), 7 deletions(-)
diff --git
a/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/template.hbs
b/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/template.hbs
index 5fd0080..41a8a34 100644
--- a/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/template.hbs
+++ b/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/template.hbs
@@ -77,7 +77,7 @@
<label class="te-label te-label--small">Add this alert to a subscription
group</label>
{{!-- subscription group --}}
{{#power-select
- placeholder="Create a subscription group"
+ placeholder="Create a new subscription group"
options=subscriptionGroupNamesDisplay
selected=groupName
searchField="name"
diff --git
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionMigrationResource.java
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionMigrationResource.java
index 5dd9167..3a585f2 100644
---
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionMigrationResource.java
+++
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionMigrationResource.java
@@ -129,7 +129,7 @@ public class DetectionMigrationResource {
private Map<String, Object>
translateAnomalyFunctionToYaml(AnomalyFunctionDTO anomalyFunctionDTO) {
Map<String, Object> yamlConfigs = new LinkedHashMap<>();
yamlConfigs.put("detectionName", anomalyFunctionDTO.getFunctionName());
- yamlConfigs.put("description", "<Please edit and provide a description for
this alert>");
+ yamlConfigs.put("description", "Please update description - If this alert
fires then it means so-and-so and check so-and-so for irregularities");
yamlConfigs.put("metric", anomalyFunctionDTO.getMetric());
yamlConfigs.put("active", anomalyFunctionDTO.getIsActive());
yamlConfigs.put("dataset", anomalyFunctionDTO.getCollection());
diff --git
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/LegacyAnomalyFunctionTranslator.java
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/LegacyAnomalyFunctionTranslator.java
index 0735406..372f8eb 100644
---
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/LegacyAnomalyFunctionTranslator.java
+++
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/LegacyAnomalyFunctionTranslator.java
@@ -86,7 +86,7 @@ public class LegacyAnomalyFunctionTranslator {
DetectionConfigDTO config = new DetectionConfigDTO();
config.setName(anomalyFunctionDTO.getFunctionName());
- config.setDescription("<Please edit and provide a description for this
alert>");
+ config.setDescription("Please update description - If this alert fires
then it means so-and-so and check so-and-so for irregularities");
config.setCron(anomalyFunctionDTO.getCron());
config.setProperties(properties);
config.setActive(false);
diff --git
a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/migrated-detection-config-1.json
b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/migrated-detection-config-1.json
index 15eb6a5..2843146 100644
---
a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/migrated-detection-config-1.json
+++
b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/migrated-detection-config-1.json
@@ -1,7 +1,7 @@
{
"cron":"0 0 14 * * ? *",
"name":"test_function",
- "description":"<Please edit and provide a description for this alert>",
+ "description":"Please update description - If this alert fires then it means
so-and-so and check so-and-so for irregularities",
"properties":{
"className":"org.apache.pinot.thirdeye.detection.wrapper.ChildKeepingMergeWrapper",
"nested":[
@@ -30,7 +30,7 @@
]
},
"active":true,
- "yaml":"detectionName: test_function\ndescription: <Please edit and provide
a description for this alert>\nmetric: test_metric\nactive: true\ndataset:
test_collection\npipelineType: Composite\ndimensionExploration:\n
dimensions:\n - platform\nfilters:\n platform:\n - desktop\n -
tablet\nrules:\n- detection:\n - name: detection_rule1\n type:
PERCENTAGE_RULE\n params:\n percentageChange: 0.05\n pattern:
DOWN\n",
+ "yaml":"detectionName: test_function\ndescription: Please update description
- If this alert fires then it means so-and-so and check so-and-so for
irregularities\nmetric: test_metric\nactive: true\ndataset:
test_collection\npipelineType: Composite\ndimensionExploration:\n
dimensions:\n - platform\nfilters:\n platform:\n - desktop\n -
tablet\nrules:\n- detection:\n - name: detection_rule1\n type:
PERCENTAGE_RULE\n params:\n percentageChange: 0.05\n pattern:
DOWN\n",
"componentSpecs":{
"detection_rule1:PERCENTAGE_RULE":{
"percentageChange":0.05,
diff --git
a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/migrated-detection-config-2.json
b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/migrated-detection-config-2.json
index 960dcd6..f1c3a86 100644
---
a/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/migrated-detection-config-2.json
+++
b/thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/migrated-detection-config-2.json
@@ -1,7 +1,7 @@
{
"cron":"0 0 14 * * ? *",
"name":"test_function",
- "description":"<Please edit and provide a description for this alert>",
+ "description":"Please update description - If this alert fires then it means
so-and-so and check so-and-so for irregularities",
"lastTimestamp":1547772179159,
"properties":{
"className":"org.apache.pinot.thirdeye.detection.wrapper.ChildKeepingMergeWrapper",
@@ -27,7 +27,7 @@
]
},
"active":true,
- "yaml":"detectionName: test_function\ndescription: <Please edit and provide
a description for this alert>\nmetric: test_metric\nactive: true\ndataset:
test_collection\npipelineType: Composite\nfilters:\n score_challenge_type:\n
- Captcha Challenge\nrules:\n- detection:\n - name: detection_rule1\n type:
THRESHOLD\n params:\n min: '0.70'\n",
+ "yaml":"detectionName: test_function\ndescription: Please update description
- If this alert fires then it means so-and-so and check so-and-so for
irregularities\nmetric: test_metric\nactive: true\ndataset:
test_collection\npipelineType: Composite\nfilters:\n score_challenge_type:\n
- Captcha Challenge\nrules:\n- detection:\n - name: detection_rule1\n type:
THRESHOLD\n params:\n min: '0.70'\n",
"componentSpecs":{
"detection_rule1:THRESHOLD":{
"min":"0.70",
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
