mcvsubbu commented on a change in pull request #3864: Add controller mode logic in ControllerStarter URL: https://github.com/apache/incubator-pinot/pull/3864#discussion_r260501751
########## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerStarter.java ########## @@ -77,12 +78,18 @@ private static final Long DATA_DIRECTORY_EXCEPTION_VALUE = 1100000L; private static final String METADATA_EVENT_NOTIFIER_PREFIX = "metadata.event.notifier"; + // Note: Right now we don't allow pinot-only mode to be used in production yet. + // We'll have this mode used only in tests. + // TODO: Once all the logic is in then we can remove this flag. + protected boolean _enablePinotOnlyMode = false; Review comment: I like introducing a protected method (like: boolean isPinotOnlyModeSupported()) and overriding it in tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
