jackjlli commented on a change in pull request #3864: Add controller mode logic
in ControllerStarter
URL: https://github.com/apache/incubator-pinot/pull/3864#discussion_r261024562
##########
File path: pom.xml
##########
@@ -311,6 +312,16 @@
<artifactId>testng</artifactId>
<version>6.11</version>
</dependency>
+ <dependency>
Review comment:
No, Mockito cannot mock static object. In this case, Pinot controller
contains more than 1 singleton object and we need to instantiate more than 1
pinot controller in our test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
