snleee commented on a change in pull request #3895: Fix the RecordReader to
pick incoming time column
URL: https://github.com/apache/incubator-pinot/pull/3895#discussion_r261495679
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/readers/RecordReaderFactory.java
##########
@@ -43,6 +43,7 @@ public static RecordReader
getRecordReader(SegmentGeneratorConfig segmentGenerat
return new CSVRecordReader(dataFile, schema, (CSVRecordReaderConfig)
segmentGeneratorConfig.getReaderConfig());
case JSON:
return new JSONRecordReader(dataFile, schema);
+ // TODO: PinotSegmentRecordReader abd ThriftRecordReader do not support
default value or different incoming/outgoing time column
Review comment:
`abd -> and`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
