This is an automated email from the ASF dual-hosted git repository.
snlee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 97f0a86 hadern DateTimeFormatSpecTest with locale (#3785)
97f0a86 is described below
commit 97f0a86087f99725654ccb9ec2c6a500f1e6b002
Author: Xue Yu <[email protected]>
AuthorDate: Fri Mar 1 15:58:22 2019 +0800
hadern DateTimeFormatSpecTest with locale (#3785)
---
.../java/org/apache/pinot/common/data/DateTimeFormatPatternSpec.java | 4 +++-
.../java/org/apache/pinot/common/data/DateTimeFormatSpecTest.java | 5 +++--
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git
a/pinot-common/src/main/java/org/apache/pinot/common/data/DateTimeFormatPatternSpec.java
b/pinot-common/src/main/java/org/apache/pinot/common/data/DateTimeFormatPatternSpec.java
index ca09a48..120f747 100644
---
a/pinot-common/src/main/java/org/apache/pinot/common/data/DateTimeFormatPatternSpec.java
+++
b/pinot-common/src/main/java/org/apache/pinot/common/data/DateTimeFormatPatternSpec.java
@@ -18,6 +18,7 @@
*/
package org.apache.pinot.common.data;
+import java.util.Locale;
import java.util.TimeZone;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
@@ -36,6 +37,7 @@ public class DateTimeFormatPatternSpec {
private static final int SDF_PATTERN_GROUP = 1;
private static final int TIMEZONE_GROUP = 3;
public static final DateTimeZone DEFAULT_DATETIMEZONE = DateTimeZone.UTC;
+ public static final Locale DEFAULT_LOCALE = Locale.ENGLISH;
private TimeFormat _timeFormat;
private String _sdfPattern = null;
@@ -52,7 +54,7 @@ public class DateTimeFormatPatternSpec {
String timezoneString = m.group(TIMEZONE_GROUP).trim();
_dateTimeZone =
DateTimeZone.forTimeZone(TimeZone.getTimeZone(timezoneString));
}
- _dateTimeFormatter =
DateTimeFormat.forPattern(_sdfPattern).withZone(_dateTimeZone);
+ _dateTimeFormatter =
DateTimeFormat.forPattern(_sdfPattern).withZone(_dateTimeZone).withLocale(DEFAULT_LOCALE);
}
}
diff --git
a/pinot-common/src/test/java/org/apache/pinot/common/data/DateTimeFormatSpecTest.java
b/pinot-common/src/test/java/org/apache/pinot/common/data/DateTimeFormatSpecTest.java
index 6c5d69e..ce0f4f4 100644
---
a/pinot-common/src/test/java/org/apache/pinot/common/data/DateTimeFormatSpecTest.java
+++
b/pinot-common/src/test/java/org/apache/pinot/common/data/DateTimeFormatSpecTest.java
@@ -20,6 +20,7 @@ package org.apache.pinot.common.data;
import java.util.ArrayList;
import java.util.List;
+import java.util.Locale;
import java.util.TimeZone;
import java.util.concurrent.TimeUnit;
import org.apache.pinot.common.data.DateTimeFieldSpec.TimeFormat;
@@ -106,9 +107,9 @@ public class DateTimeFormatSpecTest {
1498892400000L)});
entries.add(
new Object[]{"1:HOURS:SIMPLE_DATE_FORMAT:M/d/yyyy h:mm:ss a",
1498892400000L, String.class, DateTimeFormat
- .forPattern("M/d/yyyy h:mm:ss
a").withZoneUTC().print(1498892400000L)});
+ .forPattern("M/d/yyyy h:mm:ss
a").withZoneUTC().withLocale(Locale.ENGLISH).print(1498892400000L)});
entries.add(new Object[]{"1:HOURS:SIMPLE_DATE_FORMAT:M/d/yyyy h a",
1502066750000L, String.class, DateTimeFormat
- .forPattern("M/d/yyyy h a").withZoneUTC().print(1502066750000L)});
+ .forPattern("M/d/yyyy h
a").withZoneUTC().withLocale(Locale.ENGLISH).print(1502066750000L)});
return entries.toArray(new Object[entries.size()][]);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
